tests/core/failover: enable the test on core18 #11175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
Codecov Report
@@ Coverage Diff @@
## master #11175 +/- ##
==========================================
- Coverage 78.33% 78.33% -0.01%
==========================================
Files 920 920
Lines 104882 104882
==========================================
- Hits 82159 82156 -3
- Misses 17597 17598 +1
- Partials 5126 5128 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mardy
approved these changes
Dec 15, 2021
| @@ -109,7 +122,7 @@ execute: | | |||
| fi | |||
|
|
|||
| # check boot env vars | |||
| readlink /snap/core/current > failBoot | |||
| readlink "/snap/$core_name/current" > failBoot | |||
There was a problem hiding this comment.
Do we want $core_name or $TARGET_SNAP_NAME here?
There was a problem hiding this comment.
Good point $TARGET_SNAP_NAME, but it works by accident since there was only ever running for the core* snaps. I'm working on making it work for the kernel snap too, so I'll fix it there.
sergiocazzolato
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the test on core18