interfaces: allow access to new at-spi socket location in desktop-legacy #11208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11208 +/- ##
=======================================
Coverage 78.36% 78.36%
=======================================
Files 922 922
Lines 105128 105128
=======================================
+ Hits 82383 82384 +1
+ Misses 17613 17612 -1
Partials 5132 5132
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mvo5
added
the
Needs security review
alexmurray
removed
the
Needs security review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In at-spi 2.40, the socket location for the accessibility bus was changed from an abstract namespace socket to a regular unix socket, with the aim of making it easier to sandbox: without the help of a kernel MAC system like AppArmor, you've really only got a choice between allowing access to all abstract sockets or denying access to all sockets. In contrast, access to regular unix sockets can be controlled via mount namespace manipulation or file permissions.
Unfortunately that release changed to using a randomised socket name under
/tmp, which could not reasonably be supported with snapd's private /tmp. That issue has been fixed upstream in at-spi, presumably to be included in 2.44:https://gitlab.gnome.org/GNOME/at-spi2-core/-/issues/43
Now the socket will be named something matching
$XDG_RUNTIME_DIR/at-spi/bus*(where the exact name will depend on the value of$DISPLAY). This PR updates the desktop-legacy AppArmor rules to allow access to this socket.