packaging, bloader, github: restore cleanliness of snapd info file; check in GA workflow #11211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
This is only needed for trusty, build tags already exclude this file from being built, so it's unnecessary to do this for xenial et al. This should produce clean snapd versions again in the info/version.go files. Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
…eanliness This is to prevent committing code to PR's which result in snapd internal version being dirty, like we currently have on master. Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Copyright year for the generated bootloader asset files was out of date since the
year is now 2022, so building the snapd deb/snap resulted in this being changed.
The old_seccomp.go file is only needed for trusty, build tags already exclude this file
from being built, so it's unnecessary to do this for xenial et al.
This should produce clean snapd versions again in the info/version.go files.
Also add to the GitHub Actions snap build a check that the info file has a clean version.