Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix parallel-install-basic on external UC16 devices #11240

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

mvo5
Copy link
Contributor

@mvo5 mvo5 commented Jan 12, 2022

We saw some test failures running this test on UC16 external
devices. It turns out the failures are a side-effect of the
way tests.session exec works on UC16. Here the /snap/bin
directory is not in PATH.

The other places that use tests.session exec workaround this
by prepending snap run. This commit does the same for
the parallel-install-basic test (thanks to Maciej for the
suggestion).

We saw some test failures running this test on UC16 external
devices. It turns out the failures are a side-effect of the
way `tests.session exec` works on UC16. Here the `/snap/bin`
directory is not in `PATH`.

The other places that use `tests.session exec` workaround this
by prepending `snap run`. This commit does the same for
the `parallel-install-basic` test (thanks to Maciej for the
suggestion).
@mvo5 mvo5 added Simple 😃 A small PR which can be reviewed quickly Test Robustness labels Jan 12, 2022
@mvo5 mvo5 added this to the 2.54 milestone Jan 12, 2022
@anonymouse64
Copy link
Member

TING.md)?

typo in your commit / PR description ?

Copy link
Member

@anonymouse64 anonymouse64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@bboozzoo bboozzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bboozzoo
Copy link
Collaborator

@mvo5 can you land this?

@mvo5 mvo5 merged commit 807ad3a into snapcore:master Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked Simple 😃 A small PR which can be reviewed quickly Test Robustness
Projects
None yet
3 participants