systemd: add NeedDaemonReload to the unit state #11241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ondrej Kubik <ondrej.kubik@canonical.com>
… parameter Signed-off-by: Ondrej Kubik <ondrej.kubik@canonical.com>
Signed-off-by: Ondrej Kubik <ondrej.kubik@canonical.com>
Codecov Report
@@ Coverage Diff @@
## master #11241 +/- ##
=======================================
Coverage 78.35% 78.36%
=======================================
Files 923 923
Lines 105342 105344 +2
=======================================
+ Hits 82543 82551 +8
+ Misses 17659 17654 -5
+ Partials 5140 5139 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
For reference, the implementation of the property NeedDaemonReload on systemd side is right here: https://github.com/systemd/systemd/blob/8585b7ca65e5c5d101a935b41cd081963f790946/src/core/unit.c#L3694-L3720 |
Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
|
@mvo5 this is ready, test failure are unrelated though. Can you land it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding NeedDaemonReload to the unit state, as foundation for removing unnecessary
daemon-reloadcalls int he future.