cmd/snap: rm unnecessary validation #11249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stolowski
approved these changes
Jan 13, 2022
| @@ -480,7 +480,7 @@ type cmdInstall struct { | |||
| IgnoreValidation bool `long:"ignore-validation"` | |||
| IgnoreRunning bool `long:"ignore-running" hidden:"yes"` | |||
| Positional struct { | |||
| Snaps []remoteSnapName `positional-arg-name:"<snap>"` | |||
| Snaps []remoteSnapName `positional-arg-name:"<snap>" required:"1"` | |||
Codecov Report
@@ Coverage Diff @@
## master #11249 +/- ##
==========================================
- Coverage 78.35% 78.33% -0.03%
==========================================
Files 923 924 +1
Lines 105342 105371 +29
==========================================
+ Hits 82544 82545 +1
- Misses 17658 17686 +28
Partials 5140 5140
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a validation check for
snap installsince go-flags's validation already covers it. Apparently, if the positional struct contains a slice, the slice field must also have a required tag. I had a look at the other commands and did some testing to see if this happened anywhere else but didn't see other examples of this quirk.