check-commit-email: do not fail when current dir is not under git #11281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check fails with a source tarball, like the one used during spread tests. ``` Error: 2022-01-21 07:44:44 Error executing google:ubuntu-20.04-64:tests/unit/go (jan210735-282406) : ----- ... Obtaining c-dependencies HEAD is now at 74f4fe8 Merge pull request snapcore#63 from vasi/vasi-win-ci Checking docs fatal: not a git repository (or any of the parent directories): .git Traceback (most recent call last): File "./check-commit-email.py", line 42, in <module> commitrange = get_commit_range() File "./check-commit-email.py", line 22, in get_commit_range lines = subprocess.check_output( File "/usr/lib/python3.8/subprocess.py", line 415, in check_output return run(*popenargs, stdout=PIPE, timeout=timeout, check=True, File "/usr/lib/python3.8/subprocess.py", line 516, in run raise CalledProcessError(retcode, process.args, subprocess.CalledProcessError: Command '['git', 'cat-file', '-p', '@']' returned non-zero exit status 128. Crushing failure and despair. ``` Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
Codecov Report
@@ Coverage Diff @@
## master #11281 +/- ##
=======================================
Coverage 78.24% 78.24%
=======================================
Files 927 927
Lines 105872 105872
=======================================
+ Hits 82837 82844 +7
+ Misses 17881 17875 -6
+ Partials 5154 5153 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mardy
approved these changes
Jan 21, 2022
|
Nice catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check fails with a source tarball, like the one used during spread tests.