-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: drop 21.04 tests (it's EOL) #11283
Conversation
The 21.04 Ubuntu release is end-of-life since 2022-01-20. This commit drops the tests on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see 21.04 related things in a couple of files that aren't covered here:
- tests/main/lxd-mount-units/task.yaml
- tests/main/os.query/task.yaml
- tests/lib/pkgdb.sh
- tests/lib/nested.sh
- tests/lib/external/snapd-testing-tools/tests/os.query/task.yaml
I'm not sure all of them should be deleted but AFAICT the ones in /main probably should
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
Codecov Report
@@ Coverage Diff @@
## master #11283 +/- ##
=======================================
Coverage 78.24% 78.24%
=======================================
Files 927 927
Lines 105986 105986
=======================================
Hits 82930 82930
Misses 17899 17899
Partials 5157 5157
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The 21.04 Ubuntu release is end-of-life since 2022-01-20. This
commit drops the tests on it.
As discussed in #11274