Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: drop 21.04 tests (it's EOL) #11283

Merged
merged 4 commits into from
Jan 25, 2022
Merged

Conversation

mvo5
Copy link
Contributor

@mvo5 mvo5 commented Jan 21, 2022

The 21.04 Ubuntu release is end-of-life since 2022-01-20. This
commit drops the tests on it.

As discussed in #11274

The 21.04 Ubuntu release is end-of-life since 2022-01-20. This
commit drops the tests on it.
Copy link
Contributor

@MiguelPires MiguelPires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see 21.04 related things in a couple of files that aren't covered here:

  • tests/main/lxd-mount-units/task.yaml
  • tests/main/os.query/task.yaml
  • tests/lib/pkgdb.sh
  • tests/lib/nested.sh
  • tests/lib/external/snapd-testing-tools/tests/os.query/task.yaml

I'm not sure all of them should be deleted but AFAICT the ones in /main probably should

Copy link
Contributor

@MiguelPires MiguelPires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2022

Codecov Report

Merging #11283 (3976f34) into master (619360a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11283   +/-   ##
=======================================
  Coverage   78.24%   78.24%           
=======================================
  Files         927      927           
  Lines      105986   105986           
=======================================
  Hits        82930    82930           
  Misses      17899    17899           
  Partials     5157     5157           
Flag Coverage Δ
unittests 78.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
store/cache.go 69.23% <0.00%> (-1.93%) ⬇️
cmd/snap/cmd_debug_state.go 70.18% <0.00%> (-0.46%) ⬇️
daemon/api_connections.go 93.58% <0.00%> (+0.53%) ⬆️
overlord/hookstate/hookmgr.go 75.32% <0.00%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 619360a...3976f34. Read the comment docs.

Copy link
Contributor

@mardy mardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants