Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix incorrect link #11368

Merged
merged 1 commit into from Feb 9, 2022
Merged

docs: fix incorrect link #11368

merged 1 commit into from Feb 9, 2022

Conversation

MiguelPires
Copy link
Contributor

Fixes an incorrect link in the HACKING.md document.

@MiguelPires MiguelPires added Simple 😃 A small PR which can be reviewed quickly Documentation Skip spread Indicate that spread job should not run labels Feb 9, 2022
Copy link
Member

@anonymouse64 anonymouse64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks for fixing this after I merged too quickly :-)

Copy link
Collaborator

@bboozzoo bboozzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

It'd be good to verify whether the instructions for core18/core20 are vaguely similar.

@anonymouse64
Copy link
Member

@bboozzoo there are no similar instructions because the core 18 and core20 snaps don't include snapd and furthermore those snaps are buildable with snapcraft normally, this is just for the core snap very specifically

@bboozzoo
Copy link
Collaborator

bboozzoo commented Feb 9, 2022

@bboozzoo there are no similar instructions because the core 18 and core20 snaps don't include snapd and furthermore those snaps are buildable with snapcraft normally, this is just for the core snap very specifically

I assumed we have instructions for cases when you need to modify something in core18/20 and then repack them, which is nearly identical save for the payload

@anonymouse64
Copy link
Member

I assumed we have instructions for cases when you need to modify something in core18/20 and then repack them, which is nearly identical save for the payload

ah no I don't think we have such instructions

@codecov-commenter
Copy link

Codecov Report

Merging #11368 (5d6b7c6) into master (7381a6b) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11368      +/-   ##
==========================================
- Coverage   78.35%   78.35%   -0.01%     
==========================================
  Files         931      931              
  Lines      106551   106551              
==========================================
- Hits        83491    83489       -2     
- Misses      17860    17862       +2     
  Partials     5200     5200              
Flag Coverage Δ
unittests 78.35% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/snap/cmd_aliases.go 90.14% <0.00%> (-1.41%) ⬇️
daemon/api_connections.go 93.04% <0.00%> (-0.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7381a6b...5d6b7c6. Read the comment docs.

@MiguelPires MiguelPires merged commit 6eed59b into snapcore:master Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Simple 😃 A small PR which can be reviewed quickly Skip spread Indicate that spread job should not run
Projects
None yet
4 participants