New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix incorrect link #11368
docs: fix incorrect link #11368
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks for fixing this after I merged too quickly :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
It'd be good to verify whether the instructions for core18/core20 are vaguely similar.
@bboozzoo there are no similar instructions because the core 18 and core20 snaps don't include snapd and furthermore those snaps are buildable with snapcraft normally, this is just for the core snap very specifically |
I assumed we have instructions for cases when you need to modify something in core18/20 and then repack them, which is nearly identical save for the payload |
ah no I don't think we have such instructions |
Codecov Report
@@ Coverage Diff @@
## master #11368 +/- ##
==========================================
- Coverage 78.35% 78.35% -0.01%
==========================================
Files 931 931
Lines 106551 106551
==========================================
- Hits 83491 83489 -2
- Misses 17860 17862 +2
Partials 5200 5200
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Fixes an incorrect link in the HACKING.md document.