Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asserts: remove unused function, fix for linter #11382

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

pedronis
Copy link
Collaborator

this was flagged by deadcode/unused.

there is no obvious future use case for this anymore so I'm removing it
but this will not always be clear cut with header_checks.go functions
which is a growing helper library

this was flagged by deadcode/unused.

there is no obvious future use case for this anymore so I'm removing it
but this will not always be clear cut with header_checks.go functions
which is a growing helper library
@pedronis pedronis added ⚠ Critical High-priority stuff (e.g. to fix master) Test Robustness labels Feb 11, 2022
Copy link
Contributor

@stolowski stolowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Collaborator

@bboozzoo bboozzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #11382 (50d83b8) into master (984e5be) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11382      +/-   ##
==========================================
- Coverage   78.36%   78.36%   -0.01%     
==========================================
  Files         931      931              
  Lines      106644   106642       -2     
==========================================
- Hits        83574    83570       -4     
- Misses      17867    17868       +1     
- Partials     5203     5204       +1     
Flag Coverage Δ
unittests 78.36% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
asserts/header_checks.go 95.77% <ø> (+0.89%) ⬆️
cmd/snap/cmd_aliases.go 90.14% <0.00%> (-1.41%) ⬇️
cmd/snap/cmd_debug_state.go 70.18% <0.00%> (-0.46%) ⬇️
overlord/ifacestate/handlers.go 64.87% <0.00%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 984e5be...50d83b8. Read the comment docs.

Copy link
Member

@anonymouse64 anonymouse64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@pedronis pedronis merged commit 52b49e1 into snapcore:master Feb 14, 2022
@pedronis pedronis deleted the asserts-fix-for-linter branch February 14, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠ Critical High-priority stuff (e.g. to fix master) Test Robustness
Projects
None yet
5 participants