New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
interfaces/{cpu,power}-control: add more accesses for commercial device tuning #11404
interfaces/{cpu,power}-control: add more accesses for commercial device tuning #11404
Conversation
…ce tuning See the init_post_boot.sh[1] script for a summary of these accesses. There are other accesses we are still evaluating where to provide them, they likely belong in either custom-devices or in system-files for specific devices however. See also salesforce ticket 00320679. [1] https://source.codeaurora.org/quic/le/snap/yaml/tree/sa8155p-gadget/postboot/init_post_boot.sh?h=UC.UM.1.0.r1-00600-sa8155.0 Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
Codecov Report
@@ Coverage Diff @@
## master #11404 +/- ##
=======================================
Coverage 78.34% 78.35%
=======================================
Files 931 931
Lines 107005 107005
=======================================
+ Hits 83838 83840 +2
+ Misses 17951 17949 -2
Partials 5216 5216
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! That script has a few other accesses that are missing from here (polling_interval
, mem_latency/*
, bw_hwmon/*
); I guess we don't need them then?
These are being analyzed separately, I'm actually unsure if the for loop in the script with for device in /sys/devices/platform/soc is supposed to actually be for device in /sys/devices/platform/soc/* which will change the actual files we grant permissions for. I wanted to get these proposed while waiting for confirmation about the others |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks.
See the init_post_boot.sh[1] script for a summary of these accesses. There are
other accesses we are still evaluating where to provide them, they likely
belong in either custom-devices or in system-files for specific devices
however.
See also salesforce ticket 00320679.
[1] https://source.codeaurora.org/quic/le/snap/yaml/tree/sa8155p-gadget/postboot/init_post_boot.sh?h=UC.UM.1.0.r1-00600-sa8155.0