Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interfaces: add dbusmenu, freedesktop and kde notifications to unity7 (Closes #1573188) #1165

Merged
merged 5 commits into from May 19, 2016

Conversation

jdstrand
Copy link

No description provided.

@kyrofa
Copy link
Contributor

kyrofa commented May 13, 2016

My test case is the Qt systray example snap. This PR makes the indicator and notifications show up-- awesome job! However, the indicator has a menu with options to maximize, minimize, or quit the daemon, and selecting any of those options doesn't do anything-- you get this instead (where I clicked "quit"):

May 13 12:54:24 xenial dbus[1823]: apparmor="DENIED" operation="dbus_method_call"  bus="session" path="/MenuBar" interface="com.canonical.dbusmenu" member="AboutToShowGroup" name=":1.20" mask="receive" pid=3386 label="snap.systray.systray" peer_pid=1966 peer_label="unconfined"
May 13 12:54:26 xenial dbus[1823]: apparmor="DENIED" operation="dbus_method_call"  bus="session" path="/MenuBar" interface="com.canonical.dbusmenu" member="EventGroup" name=":1.20" mask="receive" pid=3386 label="snap.systray.systray" peer_pid=1966 peer_label="unconfined"

Is that something that should be handled here?

@jdstrand
Copy link
Author

jdstrand commented May 13, 2016

@kyrofa oh I missed the indicator. I can confirm and I'll add an additional access to this commit.

bus=session
path=/org/freedesktop/Notifications
interface=org.freedesktop.Notifications
member="{GetServerInformation,Notify}"
Copy link
Contributor

@3v1n0 3v1n0 May 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also want GetCapabilities here. Clients might use that to behave differently (especially as unity notifications don't support "actions", while they have things such as "append")

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @3v1n0 , added.

@kyrofa
Copy link
Contributor

kyrofa commented May 13, 2016

With the latest commit this works perfectly for my test-case 👍 .

@zyga
Copy link
Collaborator

zyga commented May 13, 2016

This looks good, thank you

@mvo5
Copy link
Contributor

mvo5 commented May 19, 2016

👍 Thanks a lot @jdstrand

@mvo5 mvo5 merged commit b666740 into snapcore:master May 19, 2016
@jdstrand jdstrand deleted the unity7 branch May 19, 2016 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants