Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
interfaces: add dbusmenu, freedesktop and kde notifications to unity7 (Closes #1573188) #1165
Conversation
jdstrand
added some commits
May 12, 2016
|
My test case is the Qt systray example snap. This PR makes the indicator and notifications show up-- awesome job! However, the indicator has a menu with options to maximize, minimize, or quit the daemon, and selecting any of those options doesn't do anything-- you get this instead (where I clicked "quit"):
Is that something that should be handled here? |
|
@kyrofa oh I missed the indicator. I can confirm and I'll add an additional access to this commit. |
3v1n0
reviewed
May 13, 2016
| + bus=session | ||
| + path=/org/freedesktop/Notifications | ||
| + interface=org.freedesktop.Notifications | ||
| + member="{GetServerInformation,Notify}" |
3v1n0
May 13, 2016
•
Contributor
I think you also want GetCapabilities here. Clients might use that to behave differently (especially as unity notifications don't support "actions", while they have things such as "append")
|
With the latest commit this works perfectly for my test-case |
|
This looks good, thank you |
jdstrand
added some commits
May 13, 2016
|
|
jdstrand commentedMay 13, 2016
No description provided.