interfaces: add dbusmenu, freedesktop and kde notifications to unity7 (Closes #1573188) #1165

Merged
merged 5 commits into from May 19, 2016

Conversation

Projects
None yet
5 participants
Contributor

jdstrand commented May 13, 2016

No description provided.

jdstrand added some commits May 12, 2016

Member

kyrofa commented May 13, 2016

My test case is the Qt systray example snap. This PR makes the indicator and notifications show up-- awesome job! However, the indicator has a menu with options to maximize, minimize, or quit the daemon, and selecting any of those options doesn't do anything-- you get this instead (where I clicked "quit"):

May 13 12:54:24 xenial dbus[1823]: apparmor="DENIED" operation="dbus_method_call"  bus="session" path="/MenuBar" interface="com.canonical.dbusmenu" member="AboutToShowGroup" name=":1.20" mask="receive" pid=3386 label="snap.systray.systray" peer_pid=1966 peer_label="unconfined"
May 13 12:54:26 xenial dbus[1823]: apparmor="DENIED" operation="dbus_method_call"  bus="session" path="/MenuBar" interface="com.canonical.dbusmenu" member="EventGroup" name=":1.20" mask="receive" pid=3386 label="snap.systray.systray" peer_pid=1966 peer_label="unconfined"

Is that something that should be handled here?

Contributor

jdstrand commented May 13, 2016

@kyrofa oh I missed the indicator. I can confirm and I'll add an additional access to this commit.

interfaces/builtin/unity7.go
+ bus=session
+ path=/org/freedesktop/Notifications
+ interface=org.freedesktop.Notifications
+ member="{GetServerInformation,Notify}"
@3v1n0

3v1n0 May 13, 2016

Contributor

I think you also want GetCapabilities here. Clients might use that to behave differently (especially as unity notifications don't support "actions", while they have things such as "append")

@jdstrand

jdstrand May 13, 2016

Contributor

Thanks @3v1n0 , added.

Member

kyrofa commented May 13, 2016

With the latest commit this works perfectly for my test-case 👍 .

Contributor

zyga commented May 13, 2016

This looks good, thank you

jdstrand added some commits May 13, 2016

Collaborator

mvo5 commented May 19, 2016

👍 Thanks a lot @jdstrand

@mvo5 mvo5 merged commit b666740 into snapcore:master May 19, 2016

2 of 3 checks passed

Integration tests Triggered
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.008%) to 79.534%
Details

@jdstrand jdstrand deleted the jdstrand:unity7 branch May 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment