New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
interfaces: add dbusmenu, freedesktop and kde notifications to unity7 (Closes #1573188) #1165
Conversation
My test case is the Qt systray example snap. This PR makes the indicator and notifications show up-- awesome job! However, the indicator has a menu with options to maximize, minimize, or quit the daemon, and selecting any of those options doesn't do anything-- you get this instead (where I clicked "quit"):
Is that something that should be handled here? |
@kyrofa oh I missed the indicator. I can confirm and I'll add an additional access to this commit. |
bus=session | ||
path=/org/freedesktop/Notifications | ||
interface=org.freedesktop.Notifications | ||
member="{GetServerInformation,Notify}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you also want GetCapabilities
here. Clients might use that to behave differently (especially as unity notifications don't support "actions", while they have things such as "append")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @3v1n0 , added.
With the latest commit this works perfectly for my test-case 👍 . |
This looks good, thank you |
👍 Thanks a lot @jdstrand |
No description provided.