Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/core/basic20: Enable on uc22 #11893

Merged
merged 1 commit into from
Jun 22, 2022
Merged

tests/core/basic20: Enable on uc22 #11893

merged 1 commit into from
Jun 22, 2022

Conversation

valentindavid
Copy link
Contributor

No description provided.

@valentindavid valentindavid mentioned this pull request Jun 17, 2022
Open
mvo5
mvo5 approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! it looks fine and it seems the test is also working. maybe we should rename the test to something like tests/core/basic20plus or similar and update the summary to Check basic core20+ ...`

@mvo5 mvo5 marked this pull request as ready for review June 20, 2022 08:49
MiguelPires
MiguelPires approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@MiguelPires MiguelPires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although the tests will need to be re-run because the store is returning 503s

@valentindavid valentindavid reopened this Jun 22, 2022
@mvo5 mvo5 merged commit 82d197a into snapcore:master Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bboozzoo bboozzoo bboozzoo approved these changes

@mvo5 mvo5 mvo5 approved these changes

@MiguelPires MiguelPires MiguelPires approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@valentindavid @bboozzoo @mvo5 @MiguelPires