progress: export stdout so it can be overridden by ubuntu-image #12025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiocazzolato
changed the title
pedronis
added
the
Needs Samuele review
|
@jawn-smith I think it would be cleaner if we made the ToolingStore used by Prepare use image.Stdout instead. So there is only one Stdout to switch before calling Prepare. I need to touch the ToolingStore anyway in the next couple of days, so I can try to work this in too. |
|
@jawn-smith I opened #12047 |
|
closing this in favor of #12047 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ubuntu-image has a
--quietflag that should suppress all output besides error messages. This is done per the Ubuntu CLI tool guidelinesWhen calling image.Prepare, there are two default outputs: "Fetching <snap_name>", and a progress bar for the download of the snap. The variable Stdout is already exported for the
imagepackage that prints the "Fetching" message. This PR exports the Stdout variable for theprogresspackage as well so the progress bar can also be suppressed.