o/snapstate: extend support for holding refreshes #12035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extends the 'refresh.hold' "all-snaps" hold mechanism to allow indefinite holds. Signed-off-by: Miguel Pires <miguel.pires@canonical.com>
Adds support for the system administrator to hold the refresh of a set of snaps for any amount of time. Signed-off-by: Miguel Pires <miguel.pires@canonical.com>
General refreshes will respect specific holds, in order to be more consistent with auto-refreshes. This doesn't apply to specific refreshes (snap refresh foo bar) or to "all-snaps" holds (snap refresh --hold). Allow users to hold specific snaps but still do system refreshes. Signed-off-by: Miguel Pires <miguel.pires@canonical.com>
Tests relying on auto-refreshing triggered them by setting the 'last-refresh' to distant time which would then exceed the maximum postponement limit and trigger an auto-refresh despite any holds. Since refresh can now be held indefinitely and the system starts up with a 2h hold, we need to remove this hold in order for the auto-refresh to trigger. Signed-off-by: Miguel Pires <miguel.pires@canonical.com>
mardy
reviewed
Aug 16, 2022
Signed-off-by: Miguel Pires <miguel.pires@canonical.com>
|
@mardy thanks for the feedback. I tried to answer your points, let me know if there's something expand on. I also experimented with writing an "implementation notes" document for this, which I can share if you want. It's short and tries not to overlap with the specification, but it's meant to document implementation decisions and roadblocks that might be relevant for someone trying to come up to speed on it |
Fix merge conflict in overlord/snapstate/autorefresh.go
Signed-off-by: Miguel Pires <miguel.pires@canonical.com>
pedronis
reviewed
Aug 17, 2022
Signed-off-by: Miguel Pires <miguel.pires@canonical.com>
Signed-off-by: Miguel Pires <miguel.pires@canonical.com>
pedronis
added
the
Needs Samuele review
pedronis
reviewed
Aug 19, 2022
Signed-off-by: Miguel Pires <miguel.pires@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds or extends refresh holding support for all-snaps and specific snaps in
snapstate: