Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

interfaces: steam-support allow pivot /run/media and /etc/nvidia mount #12263

Merged
merged 1 commit into from Oct 17, 2022
Merged

interfaces: steam-support allow pivot /run/media and /etc/nvidia mount #12263

merged 1 commit into from Oct 17, 2022

Conversation

ashuntu
Copy link
Contributor

@ashuntu ashuntu commented Oct 12, 2022 •
edited

Added mount for root pivot /run/media directory for Steam. Fixes canonical/steam-snap#59.

Added mount for root pivot /etc/nvidia directory for Steam. Fixes canonical/steam-snap#6.

@ashuntu ashuntu changed the title steam-support allow pivot /run/media mount steam-support allow pivot /run/media and /etc/nvidia mount Oct 12, 2022
jhenstridge
jhenstridge approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@jhenstridge jhenstridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pedronis pedronis self-requested a review October 13, 2022 08:15
@ashuntu ashuntu changed the title steam-support allow pivot /run/media and /etc/nvidia mount steam-support: allow pivot /run/media and /etc/nvidia mount Oct 13, 2022
@kenvandine kenvandine changed the title steam-support: allow pivot /run/media and /etc/nvidia mount interfaces: steam-support allow pivot /run/media and /etc/nvidia mount Oct 13, 2022
@mvo5 mvo5 added the Needs security review Can only be merged once security gave a :+1: label Oct 14, 2022
@mvo5 mvo5 added this to the 2.57 milestone Oct 14, 2022
@mvo5 mvo5 removed the Needs security review Can only be merged once security gave a :+1: label Oct 14, 2022
mvo5
mvo5 approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks extremely similar to the existing mounts so I plan to merge this without a formal security review as it had +1 from Samuele also.

@alexmurray
Copy link
Collaborator

FWIW LGTM

@mvo5 mvo5 merged commit 759e601 into snapcore:master Oct 17, 2022
@ashuntu ashuntu mentioned this pull request Oct 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmurray alexmurray alexmurray approved these changes

@mvo5 mvo5 mvo5 approved these changes

@pedronis pedronis pedronis approved these changes

@jhenstridge jhenstridge jhenstridge approved these changes

Assignees
No one assigned
Labels
cherry-picked
Projects
None yet
Milestone
2.57
5 participants
@ashuntu @alexmurray @mvo5 @pedronis @jhenstridge