interfaces: add pcscd interface #12847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #12847 +/- ##
==========================================
+ Coverage 78.59% 78.62% +0.02%
==========================================
Files 990 992 +2
Lines 122664 122821 +157
==========================================
+ Hits 96410 96568 +158
+ Misses 20184 20182 -2
- Partials 6070 6071 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 15 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
alexmurray
approved these changes
May 30, 2023
alexmurray
added
Needs security review
mvo5
added
the
Needs Samuele review
mvo5
reviewed
Jun 5, 2023
pedronis
approved these changes
Jun 5, 2023
interfaces/builtin/pcscd.go
Outdated
| package builtin | ||
|
|
||
| const pcscdSummary = `allows access to socket for communication between | ||
| PS/SC API library and PCSCD daemon.` |
There was a problem hiding this comment.
this should probably be more something like:
allows interacting with PCSD daemon (e.g. for the PS/SC API library)
mvo5
approved these changes
Jun 6, 2023
|
Thanks for the suggestion, I incorporated the proposed change. |
alexmurray
pushed a commit
to alexmurray/snapd
that referenced
this pull request
Oct 17, 2023
* interfaces: Add pcscd interface * Add high-level test for interface 'pcscd'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To access smart cards under a snapped program (bug 1843392), we need to allow it to communicate with the reader drivers via the pcscd socket.
This has already been discussed with the security team as the comment #1 in the linked bug report describes.
To create this interface I simply copied jack1.go and changed the appropriate parts.