New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
steam_support: add unshare CLONE_NEWNS to steam_support interface #13038
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #13038 +/- ##
==========================================
- Coverage 78.69% 78.68% -0.01%
==========================================
Files 999 1001 +2
Lines 123909 124304 +395
==========================================
+ Hits 97511 97812 +301
- Misses 20265 20337 +72
- Partials 6133 6155 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me and I have verified it fixes the issue reported on the steam snap.
As per the discussion in the Snapcraft forum, this PR adds
unshare CLONE_NEWNS
to the steam_support builtin interface.This change is essentially exactly @alexmurray's suggestion.