Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

steam_support: add unshare CLONE_NEWNS to steam_support interface #13038

Merged
merged 1 commit into from Aug 3, 2023

Conversation

ashuntu
Copy link
Contributor

@ashuntu ashuntu commented Jul 31, 2023

As per the discussion in the Snapcraft forum, this PR adds unshare CLONE_NEWNS to the steam_support builtin interface.

This change is essentially exactly @alexmurray's suggestion.

@codecov-commenter
Copy link

Codecov Report

Merging #13038 (23e7372) into master (4cab726) will decrease coverage by 0.01%.
Report is 35 commits behind head on master.
The diff coverage is 78.72%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master   #13038      +/-   ##
==========================================
- Coverage   78.69%   78.68%   -0.01%     
==========================================
  Files         999     1001       +2     
  Lines      123909   124304     +395     
==========================================
+ Hits        97511    97812     +301     
- Misses      20265    20337      +72     
- Partials     6133     6155      +22     
Flag Coverage Δ
unittests 78.68% <78.72%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cmd/snap/cmd_pack.go 86.66% <ø> (ø)
interfaces/builtin/kvm.go 93.02% <0.00%> (ø)
interfaces/builtin/steam_support.go 100.00% <ø> (ø)
interfaces/seccomp/backend.go 83.26% <0.00%> (+1.04%) ⬆️
overlord/assertstate/assertstate.go 76.76% <0.00%> (ø)
overlord/configstate/configcore/netplan.go 9.37% <0.00%> (-0.15%) ⬇️
overlord/snapstate/flags.go 100.00% <ø> (ø)
usersession/agent/rest_api.go 0.00% <0.00%> (ø)
overlord/snapstate/storehelpers.go 77.00% <62.50%> (-0.87%) ⬇️
osutil/kcmdline/kcmdline.go 88.61% <64.06%> (ø)
... and 31 more

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ashuntu ashuntu marked this pull request as ready for review July 31, 2023 21:45
Copy link
Collaborator

@alexmurray alexmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mvo5 mvo5 added this to the 2.61 milestone Aug 1, 2023
Copy link
Contributor

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Copy link
Contributor

@kenvandine kenvandine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me and I have verified it fixes the issue reported on the steam snap.

@pedronis pedronis changed the title steam_support: Add unshare CLONE_NEWNS to steam_support interface steam_support: add unshare CLONE_NEWNS to steam_support interface Aug 2, 2023
@mvo5 mvo5 merged commit 4143620 into snapcore:master Aug 3, 2023
48 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants