interfaces/builtin: allow access to /usr/share/javascript/{sphinxdoc,jquery} and /usr/share/sphinx_rtd_theme

[nteodosio]

LP:2032992 reports that documentation cannot be read in browsers because of the lack of allowance for /usr/share/javascript/jquery/.

I opened a discussion at the Snapcraft forum and was suggested this interface.

Is it the proper one? If yes I'll extend the test file accordingly.

[alexmurray]

LGTM.

[nteodosio]

Thanks for the review. I included extended the test file as promised.

The automated tests check the pull request title, is that really important? I'd expect it to not go beyond the commit title. Anyway, I edited it, but you'll need to manually trigger the test again apparently.

[lissyx]

What is missing to land this @nteodosio ?

[nteodosio]

I think one more person needs to approve it, judging by the fragment in the reviewers section:

"At least 2 approving reviews are required to merge this pull request."

[zyga]

While the new mount entries look relatively harmless I think there's going to be a point where we need to re-think how such documentation is accessed.

It cannot be extended indefinitely without causing problems to what is in the mount namespace.

[lissyx]

While the new mount entries look relatively harmless I think there's going to be a point where we need to re-think how such documentation is accessed.

It cannot be extended indefinitely without causing problems to what is in the mount namespace.

Agreed, I think @seb128 started something around that but I cannot find the link anymore. I regularly run into bugs filed on bugzilla because of this :(

[lissyx]

e.g., https://bugzilla.mozilla.org/show_bug.cgi?id=1768303

[Meulengracht]

@nteodosio please rebase on top of master and resolve conflicts

@zyga let's talk about this at the upcoming sprint

[Meulengracht]

@nteodosio the unit tests are failing, please handle those

[ernestl]

Checked with Nathan, this is low priority and will not be addressed in time for 2.62, moving to 2.63

[mkaply]

Can I ask why you consider this low priority? Not being able to read the docs in browsers is kind of important. There's a patch ready to go here.

[olivercalder]

I've rebased on master to pull in the latest changes, and I added the missing tests for the mount spec.

[olivercalder]

Pending spread test passage, this should be good to ship with 2.62.

[nteodosio]

Can I ask why you consider this low priority? Not being able to read the docs in browsers is kind of important.

I meant there were higher priority items on my list and that I'd look into it today or tomorrow. Thanks Oliver for taking care of it!

[Meulengracht]

Thank you, LGTM