Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/snapd-generator: read mountinfo for pid 1 (2.60) #13335

Merged
merged 2 commits into from Dec 5, 2023

Conversation

pedronis
Copy link
Collaborator

Systemd now runs generators in a sandbox. That means /proc/self/mountinfo does not represent correctly the mounts of the system.

Systemd now runs generators in a sandbox. That means
`/proc/self/mountinfo` does not represent correctly the mounts of the
system.
@pedronis pedronis requested a review from ernestl October 26, 2023 11:37
@pedronis
Copy link
Collaborator Author

this is a cherry-pick for 2.60 of a6e7fa9

Copy link
Contributor

@MiguelPires MiguelPires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@ernestl ernestl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we not update NEWS.md as well?

Copy link
Collaborator

@ernestl ernestl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3ab0acd) 78.60% compared to head (a02ff76) 78.60%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##           release/2.60   #13335   +/-   ##
=============================================
  Coverage         78.60%   78.60%           
=============================================
  Files               992      992           
  Lines            123360   123360           
=============================================
+ Hits              96962    96971    +9     
+ Misses            20282    20277    -5     
+ Partials           6116     6112    -4     
Flag Coverage Δ
unittests 78.60% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pedronis pedronis merged commit b1e223a into snapcore:release/2.60 Dec 5, 2023
24 of 50 checks passed
@pedronis pedronis deleted the fix-snapd-generator-2.60 branch December 5, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants