New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/snapd-generator: read mountinfo for pid 1 (2.60) #13335
cmd/snapd-generator: read mountinfo for pid 1 (2.60) #13335
Conversation
Systemd now runs generators in a sandbox. That means `/proc/self/mountinfo` does not represent correctly the mounts of the system.
this is a cherry-pick for 2.60 of a6e7fa9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we not update NEWS.md as well?
d768619
to
a02ff76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## release/2.60 #13335 +/- ##
=============================================
Coverage 78.60% 78.60%
=============================================
Files 992 992
Lines 123360 123360
=============================================
+ Hits 96962 96971 +9
+ Misses 20282 20277 -5
+ Partials 6116 6112 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Systemd now runs generators in a sandbox. That means
/proc/self/mountinfo
does not represent correctly the mounts of the system.