o/snapstate/autorefresh: do not expect a valid time string in refresh.hold #13544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeyadYasser
approved these changes
Feb 5, 2024
bboozzoo
added
the
Needs Samuele review
….hold It is possible that refresh.hold has been set to "forever" even before snapd ran for the first time. Reference: https://bugs.launchpad.net/bugs/2051917 Signed-off-by: Maciej Borzecki <maciej.borzecki@canonical.com>
bboozzoo
force-pushed
the
bboozzoo/at-seed-forever-hold
branch
from
a77ade3
to
522c4fc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #13544 +/- ##
=======================================
Coverage 78.86% 78.87%
=======================================
Files 1033 1033
Lines 132065 132067 +2
=======================================
+ Hits 104159 104166 +7
+ Misses 21404 21401 -3
+ Partials 6502 6500 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pedronis
approved these changes
Feb 16, 2024
|
@Meulengracht this can be force merged now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible that refresh.hold has been set to "forever" even before snapd ran for the first time.
Reference: https://bugs.launchpad.net/bugs/2051917