Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: add details to a new set of tests - part 10 #13865

Merged
merged 12 commits into from Apr 24, 2024
Merged

tests: add details to a new set of tests - part 10 #13865

merged 12 commits into from Apr 24, 2024

Conversation

sergiocazzolato
Copy link
Collaborator

add test details

@sergiocazzolato sergiocazzolato added the Simple 😃 A small PR which can be reviewed quickly label Apr 19, 2024
@sergiocazzolato sergiocazzolato added the Skip spread Indicate that spread job should not run label Apr 22, 2024
MiguelPires
MiguelPires approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@MiguelPires MiguelPires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, just some minor suggestions

tests/lib/tools/suite/fs-state/task.yaml Outdated Show resolved Hide resolved
tests/lib/tools/suite/journal-state/task.yaml Outdated Show resolved Hide resolved
tests/lib/tools/suite/mountinfo.query/task.yaml Outdated Show resolved Hide resolved
tests/lib/tools/suite/tests.session/task.yaml Outdated Show resolved Hide resolved
tests/lib/tools/suite/version-compare/task.yaml Outdated Show resolved Hide resolved
tests/main/revert/task.yaml Outdated Show resolved Hide resolved
tests/main/snaps-state/task.yaml Outdated Show resolved Hide resolved
tests/main/user-data-handling/task.yaml Outdated Show resolved Hide resolved
tests/lib/tools/suite/tests.env/task.yaml Outdated Show resolved Hide resolved
tests/lib/tools/suite/tests.session-support/task.yaml Outdated Show resolved Hide resolved
sergiocazzolato and others added 10 commits April 24, 2024 09:01
@sergiocazzolato @MiguelPires
Update tests/lib/tools/suite/fs-state/task.yaml
81a56ce 
Co-authored-by: Miguel Pires <miguelpires94@gmail.com>
@sergiocazzolato @MiguelPires
Update tests/lib/tools/suite/journal-state/task.yaml
bdb1b4d 
Co-authored-by: Miguel Pires <miguelpires94@gmail.com>
@sergiocazzolato @MiguelPires
Update tests/lib/tools/suite/mountinfo.query/task.yaml
d2fb0d2 
Co-authored-by: Miguel Pires <miguelpires94@gmail.com>
@sergiocazzolato @MiguelPires
Update tests/lib/tools/suite/tests.session/task.yaml
d05c755 
Co-authored-by: Miguel Pires <miguelpires94@gmail.com>
@sergiocazzolato @MiguelPires
Update tests/lib/tools/suite/version-compare/task.yaml
30f5b0d 
Co-authored-by: Miguel Pires <miguelpires94@gmail.com>
@sergiocazzolato @MiguelPires
Update tests/main/revert/task.yaml
a73a509 
Co-authored-by: Miguel Pires <miguelpires94@gmail.com>
@sergiocazzolato @MiguelPires
Update tests/main/snaps-state/task.yaml
d54134f 
Co-authored-by: Miguel Pires <miguelpires94@gmail.com>
@sergiocazzolato @MiguelPires
Update tests/main/user-data-handling/task.yaml
e8d7ae8 
Co-authored-by: Miguel Pires <miguelpires94@gmail.com>
@sergiocazzolato @MiguelPires
Update tests/lib/tools/suite/tests.env/task.yaml
1d2a27b 
Co-authored-by: Miguel Pires <miguelpires94@gmail.com>
@sergiocazzolato @MiguelPires
Update tests/lib/tools/suite/tests.session-support/task.yaml
687a7f4 
Co-authored-by: Miguel Pires <miguelpires94@gmail.com>
ZeyadYasser
ZeyadYasser approved these changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@ZeyadYasser ZeyadYasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

small nitpick, some sections don't end with a full stop.

@sergiocazzolato sergiocazzolato merged commit ddcf5bd into snapcore:master Apr 24, 2024
47 checks passed
@sergiocazzolato sergiocazzolato deleted the tests-add-details-part10 branch April 24, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelPires MiguelPires MiguelPires approved these changes

@ZeyadYasser ZeyadYasser ZeyadYasser approved these changes

@ernestl ernestl Awaiting requested review from ernestl

@andrewphelpsj andrewphelpsj Awaiting requested review from andrewphelpsj

Assignees
No one assigned
Labels
Simple 😃 A small PR which can be reviewed quickly Skip spread Indicate that spread job should not run
Projects
None yet
Milestone
No milestone
3 participants
@sergiocazzolato @MiguelPires @ZeyadYasser