Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data/selinux: update policy to allow stat of /run/systemd/container #13872

Conversation

bboozzoo
Copy link
Collaborator

Since 3cfa28a snap-confine checks if the system is running in a container. It does so by reading /run/systemd/container. Extend the SELinux to allow basic search operations within /run/systemd. It is unlikely anyone runs snapd in a container where the SELinux is enabled on the host, so the actual file read permissions are likely not needed.

Since 3cfa28a snap-confine checks if the system is running in a container. It
does so by reading /run/systemd/container. Extend the SELinux to allow basic
search operations within /run/systemd. It is unlikely anyone runs snapd in a
container where the SELinux is enabled on the host, so the actual file read
permissions are likely not needed.

Signed-off-by: Maciej Borzecki <maciej.borzecki@canonical.com>
@bboozzoo bboozzoo requested review from zyga and ernestl April 22, 2024 08:25
@ernestl ernestl added this to the 2.63 milestone Apr 22, 2024
@ernestl ernestl added the Simple 😃 A small PR which can be reviewed quickly label Apr 22, 2024
Copy link
Collaborator

@ernestl ernestl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ernestl
Copy link
Collaborator

ernestl commented Apr 22, 2024

Discussed with Maciek, failures not related to changes, fix confirmed to work. Centos build failure relates to external changes that require spec change.

@ernestl ernestl merged commit d6668f5 into snapcore:master Apr 22, 2024
36 of 44 checks passed
ernestl pushed a commit to ernestl/snapd that referenced this pull request Apr 23, 2024
…napcore#13872)

Since 3cfa28a snap-confine checks if the system is running in a container. It
does so by reading /run/systemd/container. Extend the SELinux to allow basic
search operations within /run/systemd. It is unlikely anyone runs snapd in a
container where the SELinux is enabled on the host, so the actual file read
permissions are likely not needed.

Signed-off-by: Maciej Borzecki <maciej.borzecki@canonical.com>
ernestl pushed a commit that referenced this pull request Apr 24, 2024
…13872)

Since 3cfa28a snap-confine checks if the system is running in a container. It
does so by reading /run/systemd/container. Extend the SELinux to allow basic
search operations within /run/systemd. It is unlikely anyone runs snapd in a
container where the SELinux is enabled on the host, so the actual file read
permissions are likely not needed.

Signed-off-by: Maciej Borzecki <maciej.borzecki@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked Simple 😃 A small PR which can be reviewed quickly
Projects
None yet
4 participants