Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store: download deltas if explicitly enabled #2017

Merged
merged 6 commits into from
Sep 29, 2016
Merged

store: download deltas if explicitly enabled #2017

merged 6 commits into from
Sep 29, 2016

Commits on Sep 29, 2016

  1. Download deltas (but do nothing with them yet) when env var is set.

    Michael Nelson committed Sep 29, 2016
    Configuration menu
    Copy the full SHA
    3c6c8cc View commit details
    Browse the repository at this point in the history

  2. Ensure either the success or failure log message is executed, but not… 

    … both.
    Michael Nelson committed Sep 29, 2016
    Configuration menu
    Copy the full SHA
    47fcc03 View commit details
    Browse the repository at this point in the history

  3. Review feedback: 

     * Be explicit about the expected content of info.DownloadInfo.Deltas
 * Merge similar tests with test cases.
 * Use a more explicitly experimental env var name
 * Other minor fixes.
    Michael Nelson committed Sep 29, 2016
    Configuration menu
    Copy the full SHA
    b1d5adb View commit details
    Browse the repository at this point in the history

  4. Simplify client to request a single delta format only and therefore 

    only expect a single delta download in response.
    Michael Nelson committed Sep 29, 2016
    Configuration menu
    Copy the full SHA
    4b6d3f0 View commit details
    Browse the repository at this point in the history

  5. Fix the error strings (lower-case). 

    Defer the close of the delta download to ensure it always happens.
Test structs don't need public attributes.
    Michael Nelson committed Sep 29, 2016
    Configuration menu
    Copy the full SHA
    975a477 View commit details
    Browse the repository at this point in the history

  6. Rename the env var switch for deltas to use SNAPD_ prefix. 

    Add more context to delta-related error message.
    Michael Nelson committed Sep 29, 2016
    Configuration menu
    Copy the full SHA
    1419b6c View commit details
    Browse the repository at this point in the history