many: move firstboot code into the snapd daemon #2033

mvo5 · 2016-09-29T15:05:43Z

This drops the firstboot systemd job we currently have and replace it with code inside snapd itself.

But keep `snap firstboot` around because we can not update files in the writable area once they are moved out of the snap (yes, this sucks!).

…irstboot

niemeyer

A few suggestions, and LGTM

niemeyer · 2016-09-30T17:02:45Z

cmd/snap/cmd_first_boot.go

-	return boot.FirstBoot()
+	println(`
+This command does nothing, its only there because we can not update files 
+in the writable space after they got copied out of the snap.


Would be nice to perhaps do:

fmt.Fprintf(Stderr, "firstboot command is deprecated")

and comment more clearly about the circumstances which makes us keep this in place, so that we won't forget either to keep it or to remove it, once we feel it's time to do that.

Thanks, done. The old message was really more meant for you/the other reviewers as a reminder that we need to think a bit about the writable space :)

niemeyer · 2016-09-30T17:09:04Z

overlord/boot/firstboot.go

-	ovld, err := overlord.New()
+func PopulateStateFromSeed(st *state.State) error {
+	// check that the state is empty
+	all, err := snapstate.All(st)


Should we check something more explicit, such as as "seeded" flag? I'm concerned about the possibility of a seeded state that has no snaps (think classic).

Question still open here.

Indeed, sorry for the slow reply. This is added now.

niemeyer · 2016-09-30T17:12:42Z

overlord/boot/firstboot.go

@@ -111,31 +94,13 @@ func populateStateFromSeed() error {
 		return nil
 	}

-	st.Lock()
 	msg := fmt.Sprintf("First boot seeding")


Can we please tweak that to a more user-oriented "Initialize system state"?

Good point, done.

niemeyer · 2016-09-30T17:13:58Z

overlord/devicestate/devicemgr.go

+	m.state.Lock()
+	defer m.state.Unlock()
+
+	// FIXME: enable on classic?


Yeah, let's enable it, but let's do that later as we need to review our model assertions and make sure it's all hanging together for old installations.

niemeyer · 2016-09-30T17:16:55Z

overlord/devicestate/devicemgr.go

+		return nil
+	}
+
+	all, err := snapstate.All(m.state)


Added a tech debt microtask item to our board:

Add snapstate.IsEmpty to avoid len(snapstate.All(st)) == 0 checks

niemeyer · 2016-09-30T17:22:05Z

overlord/snapstate/snapmgr.go

+	// a failed boot that falls back to the previous version for
+	// example)
+	m.state.Lock()
+	wasRun := m.state.Cached(cachedUpdateRevisionsWasRun{})


Can we use a simpler bool like m.firstEnsure?

Sure, fixed.

niemeyer · 2016-09-30T17:22:59Z

overlord/snapstate/snapmgr.go

+	if wasRun == nil {
+		m.state.Lock()
+		err := UpdateRevisions(m.state)
+		m.state.EnsureBefore(0)


Can we let UpdateRevisions itself do that if actually necessary? Otherwise we're assuming we know what happened there.

Thanks, yes, this moved into UpdateRevisions()

niemeyer · 2016-09-30T17:34:07Z

overlord/snapstate/check_snap.go

@@ -55,6 +54,15 @@ func checkAssumes(s *snap.Info) error {

 var openSnapFile = backend.OpenSnapFile

+// FIXME: drop and get the gadget name from the model assertion instead
+func isFirstBoot(st *state.State) bool {
+	chg := st.Change("1")


We can easily have a different initial change without realizing we're breaking this.

I suggest dropping the use of isFirstBoot below, and adding a card for the RC to fix the race condition properly. During normal working, the remaining logic will catch and prevent the problem.

I dropped this.

niemeyer · 2016-09-30T17:36:52Z

overlord/snapstate/booted.go

@@ -94,7 +89,9 @@ func UpdateRevisions(ovld *overlord.Overlord) error {
 		for snapName, snapState := range installed {
 			if name == snapName {
 				if rev != snapState.Current {
-					ts, err := snapstate.RevertToRevision(st, name, rev, snapstate.Flags(0))
+					// FIXME: check that there is no task


This is already done. We just need to make the error have a proper type and enough metadata so we can tell we're ignoring the right thing here.

Let's please add a card to the RC to fix that. This sounds like the sort of thing that may break down a device permanently in the wild.

Thanks, I added a card https://trello.com/c/oJhUNofF for this.

…irstboot

pedronis · 2016-10-05T19:10:38Z

cmd/snap/cmd_booted.go

-		return err
-	}
-	return boot.UpdateRevisions(ovld)
+	fmt.Fprintf(Stderr, "firstboot command is deprecated")


should it say booted command ?

Indeed, good catch.

pedronis · 2016-10-05T19:11:24Z

cmd/snap/cmd_booted.go

-	"github.com/snapcore/snapd/overlord"
-	"github.com/snapcore/snapd/overlord/boot"
-	"github.com/snapcore/snapd/partition"
-	"github.com/snapcore/snapd/release"
 )

 type cmdBooted struct{}


needs the same kind of comment as firstboot?

Yes, added that.

pedronis · 2016-10-05T19:12:32Z

image/image.go

@@ -38,6 +38,9 @@ import (
 	"github.com/snapcore/snapd/snap"
 	"github.com/snapcore/snapd/snap/squashfs"
 	"github.com/snapcore/snapd/store"
+
+	// important so that the testkeys get imported


as I said we should organize things differently but we can work that out during RC, is not visible to users

pedronis · 2016-10-05T19:16:22Z

overlord/boot/firstboot.go

 	assertSeedDir := filepath.Join(dirs.SnapSeedDir, "assertions")
 	dc, err := ioutil.ReadDir(assertSeedDir)
+	if os.IsNotExist(err) {


notice that in that case there will be no model though, anyway I suppoe prepare-image atm always put that dir there

pedronis · 2016-10-05T19:17:27Z

overlord/boot/firstboot.go

-
-	st.EnsureBefore(0)
-	<-chg.Ready()
+	snapstate.SetGlobalFlag(st, snapstate.Seeded)


if I understand this means we will not try to make this change again even if it failed, I suppose that's ok until we learn something else

also should this be flags|snapstate.Seeded if we go with flags?

As discussed I reworked this to a single flag in the state. Much simpler and nicer this way.

pedronis · 2016-10-05T19:20:31Z

overlord/devicestate/devicemgr.go

+		return nil
+	}
+
+	for _, chg := range m.state.Changes() {


do we need this now? afaict PopulateStateFromSeed will make the change once and commit and then never work again because of the flag

I was thinking we need it for the case when PopulateStateFromSeed will trigger the change and then the system reboots. It will reach firstboot again and the "seeded" flag is not set in the state because the changes are not finished yet (well, currently the flag is set before the tasks are all completed so there it is unneeded, however if we set it only after the seed tasks are all successful we need this check).

pedronis · 2016-10-05T19:22:13Z

overlord/snapstate/snapstate.go

+)
+
+// GlobalFlags returns a set of flags related to the snapstate
+func GlobalFlags(s *state.State) (int, error) {


not sure why don't simply use top level bools instate for this ?

Yes, did that now, thank you!

pedronis · 2016-10-05T19:29:27Z

overlord/devicestate/devicemgr.go

+		logger.Debugf("Ignoring 'booted' on classic")
+		return nil
+	}
+


the rest of this function doesn't seem tested

pedronis · 2016-10-05T19:29:55Z

overlord/devicestate/devicemgr.go

+	// settles we disable it.
+	if release.OnClassic {
+		return nil
+	}


the rest of this function doesn't seem to be tested

Indeed, sorry for that, I added tests for this now.

pedronis · 2016-10-06T07:23:48Z

overlord/managers_test.go

@@ -144,6 +148,22 @@ func makeTestSnap(c *C, snapYamlContent string) string {
 	return snaptest.MakeTestSnapWithFiles(c, snapYamlContent, nil)
 }

+func (ms *mgrsSuite) makePopulatedState(c *C) {


this is not needed anymore I suppose

Thanks, I removed it.

pedronis · 2016-10-06T07:24:43Z

overlord/snapstate/check_snap_test.go

@@ -204,11 +199,19 @@ func (s *checkSnapSuite) TestCheckSnapGadgetMissingPrior(c *C) {
 	st.Lock()
 	defer st.Unlock()

+	snapstate.Set(st, "not-firstboot", &snapstate.SnapState{


set seeded instead

Indeed, fixed.

pedronis · 2016-10-06T09:53:42Z

tests/main/firstboot-assertions/task.yaml

@@ -10,20 +10,26 @@ prepare: |
    touch $SEED_DIR/seed.yaml


I think this test is removing stamp which is not needed anymore right?

yes, thank you! removed.

pedronis · 2016-10-06T10:00:06Z

overlord/snapstate/booted.go

@@ -54,7 +51,7 @@ func nameAndRevnoFromSnap(sn string) (string, snap.Revision, error) {
 // still has the "active" version set to "v2" which is
 // misleading. This code will check what kernel/os booted and set
 // those versions active.


Can we add here something like "To do this it creates a Change and kick starts it directly."

Good point, added.

pedronis · 2016-10-06T10:02:59Z

overlord/snapstate/booted.go

-	st := ovld.State()
-	st.Lock()
-	installed, err := snapstate.All(st)
+	installed, err := All(st)


not a blocker, but still wondering why this doesn't just use snapstate.CurrentInfo(st, kernelSnap|osSnap) instead of All

Yeah, I think this is pretty old code, I fixed it to use CurrentInfo() now.

pedronis · 2016-10-06T10:07:44Z

overlord/devicestate/devicemgr_test.go

+	c.Assert(called, Equals, false)
+}
+
+func (s *deviceMgrSuite) TestDeviceManagerEnsureSeedYamlHappy(c *C) {


do we want a run-through version, so we test doMarkSeed ?

Yes, I think this is a good idea, slightly worried about timing. I will work on it after lunch.

pedronis · 2016-10-06T10:13:42Z

overlord/devicestate/devicemgr.go

+		return fmt.Errorf(i18n.G("cannot mark boot successful: %s"), err)
+	}
+
+	if err := partition.MarkBootSuccessful(bootloader); err != nil {


is this going to write the boot env each 5 minutes? maybe we should have a flag on m that we set just after this one, so we do it once per snapd invocation

Excellent point, it will run this every 5min. It won't actually write the bootloader bits every 5min because it checks internally if the var has actually changed. However its still silly, so added a flag.

sorry, maybe I wasn't clear, I would have put the flag only around MarkBootSuccessful itself

pedronis · 2016-10-06T11:49:53Z

overlord/snapstate/booted.go

-func UpdateRevisions(ovld *overlord.Overlord) error {
+// those versions active.To do this it creates a Change and kicks
+// start it directly.
+func UpdateRevisions(st *state.State) error {


didn't think of this so far but now that is under snapstate the name is a bit generic, UpdateBootRevisions ?

Yes, this makes sense, updated.

pedronis

lgtm

Imported using git-ubuntu import. Changelog parent: d92891f New changelog entries: * New upstream release, LP: #1637215: - release: os-release on core has changed - tests: /dev/ptmx does not work on powerpc, skip here - docs: moved to github.com/snapcore/snapd/wiki (snapcore#2258) - debian: golang is not installable on powerpc, use golang-any * New upstream release, LP: #1637215: - overlord/ifacestate: add unit tests for undo of setup-snap- security (snapcore#2243) - daemon,overlord,snap,tests: download to .partial in final dir (snapcore#2237) - overlord/state: marshaling tests for lanes (snapcore#2245) - overlord/state: introduce state lanes (snapcore#2241) - overlord/snapstate: fix revert+refresh (snapcore#2224) - interfaces/sytemd: enable/disable generated service units (snapcore#2229) - many: fix incorrect security files generation on undo - overlord/snapstate: add dynamic snapdX.Y assumes (snapcore#2227) - interfaces: network-manager: give slot full read-write access to /run/NetworkManager - docs: update the name of the command for the cross-build - overlord/snapstate: fix missing argument to Noticef - snapstate: ensure gadget/core/kernel can not be disabled (snapcore#2218) - asserts: limit to 1y only if len(models) == 0 (snapcore#2219) - debian: only install share/locale if available (missing on powerpc) - overlrod/snapstate: fix revert followed by refresh to old-current (snapcore#2214) - interfaces/builtin: network-manager and bluez can change hostname (snapcore#2204) - snap: switch the auto-import dir to /run/snapd/auto-import - docs: less details about cloud.cfg as requested in trello (snapcore#2206) - spread.yaml: Ensure ubuntu user has passwordless sudo for autopkgtests (snapcore#2201) - interfaces/builtin: add dcdbas-control interface - boot: do not set boot to try mode if the revision is unchanged - interfaces: add shutdown interface (snapcore#2162) - interfaces: add system-power-control interface - many: use the new systemd backend for configuring GPIOs - overlord/ifacestate: setup security for slots before plugs - snap: spool assertion candidates if snapd is not up yet - store,daemon,overlord: download things to a partials dir - asserts,daemon: implement system-user-authority header/concept - interfaces/builtin: home base declaration rule using on-classic for its policy - interfaces/builtin: finish decl based checks - asserts: bump snap-declaration to allow signing with new-style plugs and slots - overlord: checks for kernel installation/refresh based on model assertion and previous kernel - tests/lib/fakestore: fix logic to distinguish assertion not found errors - client: add a few explicit error types (around the request cycle) - tests/lib/fakestore/cmd/fakestore: make it log, and fix a typo - overlord/snapstate: two bugs for one - snappy: disable auto-import of assertions on classic (snapcore#2122) - overlord/snapstate: move trash cleanup to a cleanup handler (snapcore#2173) - daemon: make create-user --known fail on classic without --force- managed (snapcore#2123) - asserts,interfaces/policy: implement on-classic plug/slot constraints - overlord: check that the first installed gadget matches the model assertion - tests: use the snapd-control-consumer snap from the store - cmd/snap: make snap run not talk to snapd for finding the revision - snap/squashfs: try to hard link instead of copying. Also, switch to osutil.CopyFile for cp invocation. - store: send supported max-format when retrieving assertions - snapstate, devicestate: do not remove seed - boot,image,overlord,partition: read/write boot variables in single operation - tests: reenable ubuntu-core tests on qemu - asserts,interfaces/policy: allow OR-ing of subrule constraints in plug/slot rules - many: move from flags as ints to flags as structs-of-bools (snapcore#2156) - many: add supports for keeping and finding assertions with different format iterations - snap: stop using ubuntu-core-launcher, use snap-confine - many: introduce an assertion format iteration concept, refuse to add unsupported assertion - interfaces: tweak wording and comment - spread.yaml: dump apparmor denials on spread failure - tests: unflake ubuntu-core-reboot (snapcore#2150) - cmd/snap: tweak unknown command error message (snapcore#2139) - client,daemon,cmd: add payment-declined error kind (snapcore#2107) - cmd/snap: update remove command help (snapcore#2145) - many: removed frameworks target and fixed service files (snapcore#2138) - asserts,snap: validate attributes to a JSON-compatible type subset (snapcore#2140) - asserts: remove unused serial-proof type - tests: skip auto-import tests on systems without test keys (snapcore#2142) - overlord/devicestate: don't spam the debug log on classic (snapcore#2141) - cmd/snap: simplify auto-import mountinfo parsing (snapcore#2135) - tests: run ubuntu-core upgrades on isolated machine (snapcore#2137) - overlord/devicestate: recover seeding from old external approach (snapcore#2134) - overlord: merge overlord/boot pkg into overlord/devicestate (snapcore#2118) - daemon: add postCreateUserSuite test suite (snapcore#2124) - tests: abort tests if an update process is scheduled (snapcore#2119) - snapstate: avoid reboots if nothing in the boot setup has changed (snapcore#2117) - cmd/snap: do not auto-import from loop or non-dev devices (snapcore#2121) - tests: add spread test for `snap auto-import` (snapcore#2126) - tests: add test for auto-mount assertion import (snapcore#2127) - osutil: add missing unit tests for IsMounted (snapcore#2133) - tests: check for failure creating user on managed ubuntu-core systems (snapcore#2096) - snap: ignore /dev/loop addings from udev (snapcore#2111) - tests: remove snapd.boot-ok reference (snapcore#2109) - tests: enable tests related to the home interface in all-snaps (snapcore#2106) - snapstate: only import defaults from gadget on install (snapcore#2105) - many: move firstboot code into the snapd daemon (snapcore#2033) - store: send correct JSON type of string for expected payment amount (snapcore#2103) - cmd/snap: rename is-managed to managed and tune (snapcore#2102) - interfaces,overlord/ifacestate: initial cleaning up of no arg AutoConnect related bits (snapcore#2090) - client, cmd: prompt for password when buying (snapcore#2086) - snapstate: fix hanging `snap remove` if snap is no longer mounted - image: support gadget specific cloud.conf file (snapcore#2101) - cmd/snap,ctlcmd: fix behavior of snap(ctl) get (snapcore#2093) - store: local users download from the anonymous url (snapcore#2100) - docs/hooks.md: fix typos (snapcore#2099) - many: check installation of slots and plugs against declarations - docs: fix missing "=" in the systemd-active docs - store: do not set store auth for local users (snapcore#2092) - interfaces,overlord/ifacestate: use declaration-based checking for auto-connect (snapcore#2071) - overlord, daemon, snap: support gadget config defaults (snapcore#2082)The main semantic changes are: - tests: fix snap-disconnect tests after core rename (snapcore#2088) - client,daemon,overlord,cmd: add /v2/users and create-user on auto- import (snapcore#2074) - many: abbreviated forms of disconnect (snapcore#2066) - asserts: require lowercase model until insensitive matching is ready (snapcore#2076) - cmd/snap: add version command, same as --version (snapcore#2075) - all: use "core" by default but allow "ubuntu-core" still (snapcore#2070) - overlord/devicestate, docs/hooks.md: nest prepare-device configuration options - daemon: fix login API to return local macaroons (snapcore#2078) - daemon: do not hardcode UID in userLookup (snapcore#2080) - client, cmd: connect fixes (snapcore#2026) - many: preparations for switching most of autoconnect to use the declarationsfor now: - overlord/auth: update CheckMacaroon to verify local snapd macaroons (snapcore#2069) - cmd/snap: trivial auto-import and download tweaks (snapcore#2067) - interfaces: add repo.ResolveConnect that handles name resolution - interfaces/policy: introduce InstallCandidate and its checks - interfaces/policy,overlord: check connection requests against the declarations in ifacestate - many: setup snapd macaroon for local users (snapcore#2051)Next step: do snapd macaroons verification. - interfaces/policy: implement snap-id/publisher-id checks - many: change Connect to take ConnRef instead of strings (snapcore#2060) - snap: auto mount block devices and import assertions (snapcore#2047) - daemon: add `snap create-user --force-managed` support (snapcore#2041) - docs: remove references to removed buying features (snapcore#2057) - interfaces,docs: allow sharing SNAP{,_DATA,_COMMON} via content iface (snapcore#2063) - interfaces: add Plug/Slot/Connection reference helpers (snapcore#2056) - client,daemon,cmd/snap: improve create-user APIs (snapcore#2054) - many: introduce snap refresh --ignore-validation <snap> to override refresh validation (snapcore#2052) - daemon: add support for `snap create-user --known` (snapcore#2040) - interfaces/policy: start of interface policy checking code based on declarations (snapcore#2050) - overlord/configstate: support nested configuration (snapcore#2039) - asserts,interfaces/builtin,overlord/assertstate: introduce base- declaration (snapcore#2037) - interfaces: builtin: Allow writing DHCP lease files to /run/NetworkManager/dhcp (snapcore#2049) - many: remove all traces of the /v2/buy/methods endpoint (snapcore#2045) - tests: add external spread backend (snapcore#1918) - asserts: parse the slot rules in snap-declarations (snapcore#2035) - interfaces: allow read of /etc/ld.so.preload by default for armhf on series 16 (snapcore#2048) - store: change purchase to order and store clean up first pass (snapcore#2043) - daemon, store: switch to new store APIs in snapd (snapcore#2036) - many: add email to UserState (snapcore#2038) - asserts: support parsing the plugs stanza i.e. plug rules in snap- declarations (snapcore#2027) - store: apply deltas if explicitly enabled (snapcore#2031) - tests: fix create-key/snap-sign test isolation (snapcore#2032) - snap/implicit: don't restrict the camera iface to clasic (snapcore#2025) - client, cmd: change buy command to match UX document (snapcore#2011) - coreconfig: nuke it. Also, ignore po/snappy.pot. (snapcore#2030) - store: download deltas if explicitly enabled (snapcore#2017) - many: allow use of the system user assertion with create-user (snapcore#1990) - asserts,overlord,snap: add prepare-device hook for device registration (snapcore#2005) - debian: adjust packaging for trusty/deputy systemd (snapcore#2003) - asserts: introduce AttributeConstraints (snapcore#2015) - interface/builtin: access system bus on screen-inhibit-control - tests: add firewall-control interface test (snapcore#2009) - snapstate: pass errors from ListRefresh in updateInfo (snapcore#2018) - README: add links to IRC, mailing list and social media (snapcore#2022) - docs: add `configure` hook to hooks list (snapcore#2024)LP: #1596629 - cmd/snap,configstate: rename apply-config variables to configure. (snapcore#2023) - store: retry download on 500 (snapcore#2019) - interfaces/builtin: support time and date settings via 'org.freedesktop.timedate1 (snapcore#1832)

mvo5 added 15 commits September 28, 2016 19:26

Remove snapd.firstboot.service

564b0a0

But keep `snap firstboot` around because we can not update files in the writable area once they are moved out of the snap (yes, this sucks!).

move firstboot to devicemgr.go:ensureOperational

a23ceeb

Move firstboot code into the daemon

f55dee1

UpdateRevision only needs to run once per boot (thanks to Pedronis)

399dc3a

populate the state in the manager tests

4f3c74e

Merge remote-tracking branch 'upstream/master' into feature/no-more-f…

6bc384f

…irstboot

add missing ensure-before

d9d83fc

add missing FIXME

aeed21f

fix firstboot tests

ebfe992

make booted almost work

b1b6207

fix checkSnap() and firstboot

e742175

remove merge artifact

dfc62a6

remove more firstboot.service bits

0808919

Merge remote-tracking branch 'upstream/master' into feature/no-more-f…

c645f22

…irstboot

fix firstboot assertion test

eec02c9

niemeyer approved these changes Sep 30, 2016

View reviewed changes

pedronis added the ⚠ Critical High-priority stuff (e.g. to fix master) label Sep 30, 2016

mvo5 added 13 commits September 30, 2016 21:53

Merge remote-tracking branch 'upstream/master' into feature/no-more-f…

f546e75

…irstboot

add debug for suite failure

9adba01

add loop into firstboot-assertion work

a565297

review feedback

b84ec73

drop check_snap test for gadget for now

d24a727

Merge remote-tracking branch 'upstream/master' into feature/no-more-f…

e622f83

…irstboot

add missing "fmt" import

7ad072b

use ref.String() instead the cicrular dependency error

6203394

fix wait for seed changes in firstboot-assertions

aa004a5

fix prepare-image-grub test

e5733bf

add wait for firstboot

08de3bf

add debug line

61ec540

add debug for ubuntu-core-update-rollback-stresstest

842153c

mvo5 added 3 commits October 5, 2016 11:40

add seeded flags to the snapstate

7714468

add comment about cmd_first_boot.go

774d84f

move boot-ok into the daemon as well

787620c

pedronis reviewed Oct 5, 2016

View reviewed changes

mvo5 and others added 5 commits October 5, 2016 21:52

simplify seeded flag setting

5c9ff09

address review feedback

7ad0a55

extract changeInFlight helper

be6db86

add new "mark-seeded" task

6fe3cf1

fix PopulateStateFromSeed() tests

f5e92ec

pedronis reviewed Oct 6, 2016

View reviewed changes

mvo5 added 4 commits October 6, 2016 10:46

do not ignore missing assertions/ dir

e6587f4

add tests for ensureSeedYaml

f8253ab

add tests for ensureBootOk

2d11604

address review feedback

9e0ca19

pedronis reviewed Oct 6, 2016

View reviewed changes

mvo5 added 3 commits October 6, 2016 12:25

address review feedback

2550642

run m.ensureBootOk() only once instead of everytime Ensure() is called

aab57b9

simplify UpdateRevisions()

7d10dca

pedronis reviewed Oct 6, 2016

View reviewed changes

ensure mark-seeded task run is tested

9c6834e

pedronis self-assigned this Oct 6, 2016

rename snapstate.UpdateRevisions -> snapstate.UpdateBootRevisions

bad822f

pedronis removed their assignment Oct 6, 2016

mvo5 added 2 commits October 6, 2016 14:29

put bootOkRan test only around MarkBootSuccessful

4a5f9f3

move "mark-seeded" back into devicemgr.go

eb61a05

mvo5 mentioned this pull request Oct 6, 2016

devicestate: merge overlord/boot into devicestate #2108

Closed

pedronis approved these changes Oct 6, 2016

View reviewed changes

mvo5 merged commit e5011eb into snapcore:master Oct 6, 2016

many: move firstboot code into the snapd daemon #2033

many: move firstboot code into the snapd daemon #2033

Conversation

mvo5 commented Sep 29, 2016

niemeyer left a comment

Choose a reason for hiding this comment

niemeyer Sep 30, 2016 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedronis Oct 6, 2016 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedronis Oct 6, 2016 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedronis Oct 6, 2016 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedronis left a comment

Choose a reason for hiding this comment

niemeyer Sep 30, 2016 •

edited

pedronis Oct 6, 2016 •

edited

pedronis Oct 6, 2016 •

edited

pedronis Oct 6, 2016 •

edited