Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

many: abbreviated forms of disconnect #2066

Merged
merged 33 commits into from Oct 4, 2016

Commits on Apr 18, 2016

  1. interfaces: add {Plug,Slot}.Ref

    This patch adds two helpers so that it is easy to create a PlugRef from
    Plug and a SlotRef from Slot.
    
    Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
    zyga committed Apr 18, 2016
    Configuration menu
    Copy the full SHA
    d02b967 View commit details
    Browse the repository at this point in the history
  2. interfaces: add ConnRef

    This patch adds a structure representing a single connection.
    
    Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
    zyga committed Apr 18, 2016
    Configuration menu
    Copy the full SHA
    47a5852 View commit details
    Browse the repository at this point in the history
  3. interfaces: return list of affected connections and snaps from Discon…

    …nect
    
    Disconnect supports abbreviated forms where one can disconnect,
    for example, all the connections affecting a given snap.
    
    Since interface manager needs to setup security of all the affected
    snaps and to forget the persistent state of all the affected connections
    this information is now provided directly by the Disconnect
    operation.
    
    Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
    zyga committed Apr 18, 2016
    Configuration menu
    Copy the full SHA
    982d086 View commit details
    Browse the repository at this point in the history
  4. overlord/ifacestate: add support for abbreviated disconnect operations

    This patch adds support for abbreviated disconnect operations that match
    the suggestions printed by "$ snap disconnect --help". This also fixes a
    bug where snapd would crash if any of those abbreviated forms were to be
    used.
    
    Fixes: https://bugs.launchpad.net/snappy/+bug/1571497
    Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
    zyga committed Apr 18, 2016
    Configuration menu
    Copy the full SHA
    e7ba90c View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2016

  1. Merged branch 'fix-lp1571497' of https://github.com/zyga/snapd into d…

    …isconnect-short-form.
    stolowski committed Sep 28, 2016
    Configuration menu
    Copy the full SHA
    7ddcd7f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c1805ec View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2016

  1. Configuration menu
    Copy the full SHA
    faf4b63 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ec4bcae View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b44bb08 View commit details
    Browse the repository at this point in the history
  4. Added disconnectPlugOrSlot

    stolowski committed Sep 30, 2016
    Configuration menu
    Copy the full SHA
    ea0ee46 View commit details
    Browse the repository at this point in the history
  5. Cleanups, fixes

    stolowski committed Sep 30, 2016
    Configuration menu
    Copy the full SHA
    e9c2293 View commit details
    Browse the repository at this point in the history
  6. Fixes for special cases

    stolowski committed Sep 30, 2016
    Configuration menu
    Copy the full SHA
    3e9348a View commit details
    Browse the repository at this point in the history
  7. Fix help

    stolowski committed Sep 30, 2016
    Configuration menu
    Copy the full SHA
    a6f36a8 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    6eefa28 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2016

  1. Configuration menu
    Copy the full SHA
    612cc30 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2016

  1. WIP

    zyga committed Oct 3, 2016
    Configuration menu
    Copy the full SHA
    f6101eb View commit details
    Browse the repository at this point in the history
  2. interfaces: add ResolveDisconnectAll and DisconnectAll

    This patch adds a new pair of methods, ResolveDisconnectAll and
    DisconnectAll that respectively look up a list of connections to sever
    and disconect a list of connections.
    
    DisconnectAll returns a list of names of snaps that were affected by the
    operation.
    
    Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
    zyga committed Oct 3, 2016
    Configuration menu
    Copy the full SHA
    1ba25f2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    aae93f1 View commit details
    Browse the repository at this point in the history
  4. interfaces: tweak error message in ResolveDisconnectAll

    Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
    zyga committed Oct 3, 2016
    Configuration menu
    Copy the full SHA
    853b227 View commit details
    Browse the repository at this point in the history
  5. interfaces: fix typo

    Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
    zyga committed Oct 3, 2016
    Configuration menu
    Copy the full SHA
    fd17380 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2016

  1. Configuration menu
    Copy the full SHA
    7b9b6de View commit details
    Browse the repository at this point in the history
  2. interfaces: drop unlocked version of ResolveDisconnectAll

    Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
    zyga committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    fc5233a View commit details
    Browse the repository at this point in the history
  3. interfaces: don't return anything from DisconnctAll

    Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
    zyga committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    5354595 View commit details
    Browse the repository at this point in the history
  4. interfaces: tweak documentation

    Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
    zyga committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    d496ce0 View commit details
    Browse the repository at this point in the history
  5. interfaces: fix typo

    Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
    zyga committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    dc380e4 View commit details
    Browse the repository at this point in the history
  6. interfaces: drop wildcard mode on repo.Connected

    Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
    zyga committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    1c0ff1f View commit details
    Browse the repository at this point in the history
  7. interfaces: tweak error test

    Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
    zyga committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    1a1f189 View commit details
    Browse the repository at this point in the history
  8. interfaces: simplify and tweak disconnect methods and tests

    Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
    zyga committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    9bb858f View commit details
    Browse the repository at this point in the history
  9. overlord/interfaces: use new Disconnect/DisconnectAll

    This patch changes the interface manager to use the new APIs offered by
    interfaces.Repository for disconnecting. In particular we no longer
    obtain snap.Info of the affected snaps from the repository (which can
    contain stale data). Instead we use the snapstate to fetch the current
    info).
    
    In addition of the fully-spelled-out "disconnect snap:plug snap:slot" we
    now correctly support "disconnect snap:plug" or "disconnect snap:slot".
    In those two new forms the snap name can be empty (it then defaults to
    the core snap). This is thanks to the use of the new DisconnectAll
    method.
    
    Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
    zyga committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    e34153d View commit details
    Browse the repository at this point in the history
  10. overlord/ifacestate: add more disconnect tests

    Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
    zyga committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    3f88492 View commit details
    Browse the repository at this point in the history
  11. daemon: adjust tests after message changes

    Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
    zyga committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    f653e81 View commit details
    Browse the repository at this point in the history
  12. interfaces: be extra paranoid about disconnect dispatch

    Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
    zyga committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    3a3bc02 View commit details
    Browse the repository at this point in the history
  13. overlord/ifacestate: return {Plug,Slot}Ref by value

    Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
    zyga committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    98e974c View commit details
    Browse the repository at this point in the history