interfaces: update base declaration documentation and policy for on-classic and snap-type

[jdstrand]

• Finalize the documentation for various patterns of base declaration entries.
• Update bluez, fwupd, location-control, location-observe and udisks for previously documented manually-connected 'type: app' slots
• Update modem-manager and network-manager for privileged classic implicit and privileged app slot pattern
• Update pulseaudio for privileged classic implicit and privileged app slot pattern with unprivileged plugs
• update testsuite for above
• add tests for interfaces that deny-connection when not on-classic

[jdstrand]

I'm not sure why this failed since it builds fine locally:

...
dh_auto_build: go generate -v github.com/snapcore/snapd/arch github.com/snapcore/snapd/asserts github.com/snapcore/snapd/asserts/assertstest github.com/snapcore/snapd/asserts/signtool github.com/snapcore/snapd/asserts/snapasserts github.com/snapcore/snapd/asserts/sysdb github.com/snapcore/snapd/asserts/systestkeys github.com/snapcore/snapd/boot github.com/snapcore/snapd/boot/boottest github.com/snapcore/snapd/client github.com/snapcore/snapd/cmd github.com/snapcore/snapd/cmd/snap github.com/snapcore/snapd/cmd/snap-exec github.com/snapcore/snapd/cmd/snapctl github.com/snapcore/snapd/cmd/snapd github.com/snapcore/snapd/daemon github.com/snapcore/snapd/dirs github.com/snapcore/snapd/i18n github.com/snapcore/snapd/i18n/xgettext-go github.com/snapcore/snapd/image github.com/snapcore/snapd/interfaces github.com/snapcore/snapd/interfaces/apparmor github.com/snapcore/snapd/interfaces/backends github.com/snapcore/snapd/interfaces/backendtest github.com/snapcore/snapd/interfaces/builtin github.com/snapcore/snapd/interfaces/dbus github.com/snapcore/snapd/interfaces/kmod github.com/snapcore/snapd/interfaces/mount github.com/snapcore/snapd/interfaces/policy github.com/snapcore/snapd/interfaces/seccomp github.com/snapcore/snapd/interfaces/systemd github.com/snapcore/snapd/interfaces/udev github.com/snapcore/snapd/logger github.com/snapcore/snapd/notifications github.com/snapcore/snapd/osutil github.com/snapcore/snapd/overlord github.com/snapcore/snapd/overlord/assertstate github.com/snapcore/snapd/overlord/auth github.com/snapcore/snapd/overlord/configstate github.com/snapcore/snapd/overlord/devicestate github.com/snapcore/snapd/overlord/hookstate github.com/snapcore/snapd/overlord/hookstate/ctlcmd github.com/snapcore/snapd/overlord/hookstate/hooktest github.com/snapcore/snapd/overlord/ifacestate github.com/snapcore/snapd/overlord/patch github.com/snapcore/snapd/overlord/snapstate github.com/snapcore/snapd/overlord/snapstate/backend github.com/snapcore/snapd/overlord/state github.com/snapcore/snapd/partition github.com/snapcore/snapd/progress github.com/snapcore/snapd/provisioning github.com/snapcore/snapd/release github.com/snapcore/snapd/snap github.com/snapcore/snapd/snap/snapdir github.com/snapcore/snapd/snap/snapenv github.com/snapcore/snapd/snap/snaptest github.com/snapcore/snapd/snap/squashfs github.com/snapcore/snapd/store github.com/snapcore/snapd/strutil github.com/snapcore/snapd/systemd github.com/snapcore/snapd/testutil github.com/snapcore/snapd/timeout github.com/snapcore/snapd/wrappers returned exit code 1
debian/rules:53: recipe for target 'override_dh_auto_build' failed
make[1]: *** [override_dh_auto_build] Error 1
make[1]: Leaving directory '/tmp/autopkgtest.Jbif8Y/build.AuY/snapd'
debian/rules:50: recipe for target 'build' failed
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2
blame: https://github.com/snapcore/snapd.git#refs/pull/2269/head
badpkg: rules build failed with exit code 2
autopkgtest [19:53:56]: ERROR: erroneous package: rules build failed with exit code 2
Exit request sent.

[mvo5]

(nitpick) You probably want to save/defer restore the original release.OnClassic value at the beginning of this test.

[mvo5]

Thanks, looks fine, one tiny comment about the test. Ignore the autopkgtest failure for now please, we are working towards fixing the flaky test(s) but its not fully done yet (master is better and has some useful debug though).

[jdstrand]

Thanks for the merge! :)