New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

overlord: increase test timeout and improve failure message #2364

Merged

mvo5 merged 1 commit into snapcore:master from mvo5:bugfix/state-panic-race

Nov 30, 2016

Contributor

mvo5 commented Nov 28, 2016

The build on the buildds fails relatively often with:

FAIL: state_test.go:223: stateSuite.TestImplicitCheckpointPanicsAfterFailedRetries

state_test.go:241:
    // we did at least a couple
    c.Check(retries > 2, Equals, true)
... obtained bool = false
... expected bool = true

OOPS: 74 passed, 1 FAILED

E.g. see
https://launchpadlibrarian.net/295100781/buildlog_ubuntu-xenial-arm64.snapd_2.17.1+ppa110.037481fb-1_BUILDING.txt.gz
and for the list of all failures:
https://launchpad.net/~snappy-dev/+archive/ubuntu/edge/+packages?field.name_filter=&field.status_filter=&field.series_filter=

This branch should fix it by increasing the timeout and also improving the errror if it happens.


          increase timeout for TestImplicitCheckpointPanicsAfterFailedRetries t…

796fe40

…est and improve output on failure

zyga approved these changes

View reviewed changes

Collaborator

zyga left a comment

Thank you for improving this!

mvo5 merged commit 7bf1a69 into snapcore:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment