daemon: make activation optional #2627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedronis
reviewed
Jan 13, 2017
| return nil, err | ||
| } | ||
|
|
||
| if err := os.Chmod(socketPath, 0666); err != nil { |
There was a problem hiding this comment.
@chipaca wondering, is this a bit racy? is there a best/better practice?
There was a problem hiding this comment.
it is. And I was about to say no, but yes. Pushing.
pedronis
reviewed
Jan 13, 2017
| return nil, err | ||
| } | ||
|
|
||
| oldmask := unix.Umask(0111) |
There was a problem hiding this comment.
I think you want runtime.LockOSThread and friend then
pedronis
approved these changes
Jan 13, 2017
| // the listeners, so check it before using it. | ||
| d.snapListener = listener | ||
| } else { | ||
| logger.Debugf("cannot get listener for %q: %v", dirs.SnapSocket, err) |
There was a problem hiding this comment.
should we turn this into a real error now ?
There was a problem hiding this comment.
maybe leave that for after the cut?
There was a problem hiding this comment.
as you prefer, think is best
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
offered as-is. Could also add spread tests, after the standup, or spread tests can be added in a later branch.