daemon: add location header to reply for snap operations like install/remove #2690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Indeed. I suggest fixing the documentation instead of adding a Location header. We already provide the necessary data in the response. If the argument is avoiding parsing the response, that's not a great idea as it'll mean errors will also not be reported properly. If that's just to follow the RFC, it doesn't really seem to encourage this specific behavior, or at the very least it's very unclear about it. More details in #2586. |
|
Attempted closing on the basis of previous exchange on #2586 and that we already solve the real issue in the provided response (where to go next). Please feel free to reopen, though. I'll keep the LP bug open as we need to fix docs at the very least. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LP: #1654629