interfaces: miscellaneous updates for hardware-observe, kernel-module-control, unity7 and default #2768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 2, 2017 13:27
… #1660865)
Support lspci:
- allow reading /etc/modprobe.d/{,*}
- allow capability sys_admin
- allow read on @{PROC}/bus/pci/{,**} (lspci -A linux-proc)
- allow iopl syscall (lspci -A intel-conf*)
- allow read on @{PROC}/interrupts
Support lshw:
- allow read on @{PROC}/devices
- allow read on @{PROC}/ide/{,**}
- allow read on @{PROC}/scsi/{,**}
- allow read on @{PROC}/device-tree/{,**}
- allow read on /sys/kernel/debug/usb/devices
- allow read on @{PROC}/sys/abi/{,*}
Per man 2 syslog, when /proc/sys/kernel/dmesg_restrict is set, SYSLOG_ACTION_READ_ALL and SYSLOG_ACTION_SIZE_BUFFER require CAP_SYSLOG. Since consumers of this interface have legitimate reasons to check the log when this restriction is set, allow the capability.
/etc/mailname doesn't exist in core, but it may exist on classic distributions. We already allow /etc/hostname, so this isn't giving away anything more.
zyga
reviewed
Feb 2, 2017
| @@ -29,9 +29,13 @@ const kernelModuleControlConnectedPlugAppArmor = ` | |||
| capability sys_module, | |||
| @{PROC}/modules r, | |||
|
|
|||
| # NOTE: needed by lscpu. In the future this may be moved to system-trace or | |||
| # system-observe. | |||
| # FIXME: moved to physical-memory-observe (remove this in series 18) | |||
There was a problem hiding this comment.
Just as an observation. When we do series 18 we will allow people to co-install 16 and 18 base snaps and apps can use either of those. It just struck me that we should probably teach the interface layer the base snap the rule is for. The kernel-module-control interface will have to keep supplying access to /dev/mem even when 18 is around if the interface is connected to a snap using base-ubuntu-16.
… #1662306) /proc/sys/kernel/random/boot_id is a uuid that the kernel randomly generates on each boot. Since it is different for every boot, allowing read access is ok because it can't be used as an id to track the device
zyga
approved these changes
Feb 7, 2017
mvo5
approved these changes
Feb 7, 2017
bergotorino
pushed a commit
to jhodapp/snapd
that referenced
this pull request
Feb 9, 2017
The merge of snapcore#2768 made this rule obsolete therefore removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support lspci:
Support lshw: