Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
tests: parameterize gadget snap channel #3117
Conversation
|
I find this problematic because at this point we aren't using the asserted firstboot installation path for anything, we should really fix ubuntu-image to support per snap channels :/ |
|
as I proposed in standup what we could do is use ubuntu-image --channel=... |
fgimenez
added some commits
Mar 31, 2017
|
@pedronis thanks, please take a look |
zyga
added some commits
Apr 4, 2017
chipaca
approved these changes
Apr 24, 2017
Looks alright, with one nitpicky request, and a question
| + # download pc-kernel snap for the specified channel | ||
| + snap download --channel="$KERNEL_CHANNEL" pc-kernel | ||
| + | ||
| + EXTRA_FUNDAMENTAL='--extra-snaps '"$PWD"'/pc-kernel_*.snap' |
chipaca
Apr 24, 2017
Member
the quoting shenanigans going on here are valid, but best reserved for when they're needed. Here they're not: can you rewrite these like
EXTRA_FUNDAMENTAL="--extra-snaps $PWD/pc-kernel_*.snap"?
| + snap download --channel="$KERNEL_CHANNEL" pc-kernel | ||
| + | ||
| + EXTRA_FUNDAMENTAL='--extra-snaps '"$PWD"'/pc-kernel_*.snap' | ||
| + elif [ "$GADGET_CHANNEL" != edge ]; then |
chipaca
Apr 24, 2017
Member
am I wrong in understanding that this means you can't have both gadget and kernel set to non-edge unless they're both set to the same thing, otherwise the gadget gets forced to edge? Is that intended?
fgimenez
Apr 24, 2017
Contributor
Yes, this is meant to be used from spread-cron after detecting a new fundamental snap has been promoted to any of the channels, only one of them should be different from the default image channel (currently edge).
fgimenez commentedMar 31, 2017
This will allow us to create spread-cron branches to watch the promotions of the gadget snap and trigger spread executions when changes are detected.