New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: parameterize gadget snap channel #3117
tests: parameterize gadget snap channel #3117
Conversation
I find this problematic because at this point we aren't using the asserted firstboot installation path for anything, we should really fix ubuntu-image to support per snap channels :/ |
as I proposed in standup what we could do is use ubuntu-image --channel=... |
@pedronis thanks, please take a look |
…terize-gadget-channel
…terize-gadget-channel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks alright, with one nitpicky request, and a question
tests/lib/prepare.sh
Outdated
# download pc-kernel snap for the specified channel | ||
snap download --channel="$KERNEL_CHANNEL" pc-kernel | ||
|
||
EXTRA_FUNDAMENTAL='--extra-snaps '"$PWD"'/pc-kernel_*.snap' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the quoting shenanigans going on here are valid, but best reserved for when they're needed. Here they're not: can you rewrite these like
EXTRA_FUNDAMENTAL="--extra-snaps $PWD/pc-kernel_*.snap"
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thanks!
tests/lib/prepare.sh
Outdated
snap download --channel="$KERNEL_CHANNEL" pc-kernel | ||
|
||
EXTRA_FUNDAMENTAL='--extra-snaps '"$PWD"'/pc-kernel_*.snap' | ||
elif [ "$GADGET_CHANNEL" != edge ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
am I wrong in understanding that this means you can't have both gadget and kernel set to non-edge unless they're both set to the same thing, otherwise the gadget gets forced to edge? Is that intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is meant to be used from spread-cron after detecting a new fundamental snap has been promoted to any of the channels, only one of them should be different from the default image channel (currently edge).
This will allow us to create spread-cron branches to watch the promotions of the gadget snap and trigger spread executions when changes are detected.