overlord: fix TestEnsureLoopPrune not to be so racy #3140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are seeing many failures that involve the TestEnsureLoopPrune test. This test is inherently racy as it uses a actual time to wait for something to happen. In case the machine is loaded heavily and other processes contend for resources it may not get scheduled in time for this to happen. While the fix is not perfect I hope to at least decrease the frequency of the failures. We may investigate a more correct fix where timing would no longer be a factor if this is deemed insufficient. Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
This reverts commit 21d4c1b.
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
zyga
changed the title
pedronis
reviewed
Apr 5, 2017
overlord/overlord_test.go
Outdated
| @@ -370,11 +370,42 @@ func (ovs *overlordSuite) TestEnsureLoopPrune(c *C) { | |||
| chg1.AddTask(t1) | |||
| chg2 := st.NewChange("prune", "...") | |||
| chg2.SetStatus(state.DoneStatus) | |||
| t0 := chg2.SpawnTime() | |||
There was a problem hiding this comment.
conceptually this needs to be ReadyTime(), my fault
There was a problem hiding this comment.
I'll fix this in a second.
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing many failures that involve the TestEnsureLoopPrune test.
This test is inherently racy as it uses a actual time to wait for
something to happen. In case the machine is loaded heavily and other
processes contend for resources it may not get scheduled in time for
this to happen
This branch contains (now) a more sophisticated approach suggested
and demonstrated by pedronis.
Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com