Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
overlord: fix TestEnsureLoopPrune not to be so racy #3140
Conversation
zyga
added some commits
Apr 4, 2017
All checks have failed
continuous-integration/travis-ci/pr
— The Travis CI build could not complete due to an error
All checks have failed
All checks have passed
zyga
changed the title from
overlord: increase prune test wait by x10
to
overlord: fix TestEnsureLoopPrune not to be so racy
Apr 5, 2017
| @@ -370,11 +370,42 @@ func (ovs *overlordSuite) TestEnsureLoopPrune(c *C) { | ||
| chg1.AddTask(t1) | ||
| chg2 := st.NewChange("prune", "...") | ||
| chg2.SetStatus(state.DoneStatus) | ||
| + t0 := chg2.SpawnTime() |
All checks have passed
pedronis
merged commit 59472d2
into
snapcore:master
Apr 5, 2017
6 checks passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
xenial-amd64
autopkgtest finished (success)
Details
xenial-i386
autopkgtest finished (success)
Details
xenial-ppc64el
autopkgtest finished (success)
Details
yakkety-amd64
autopkgtest finished (success)
Details
zesty-amd64
autopkgtest finished (success)
Details
zyga
referenced this pull request
Apr 14, 2017
Merged
interfaces/builtin: add network-status interface #2941
zyga
deleted the
zyga:fix-prune
branch
Aug 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
zyga commentedApr 4, 2017
•
Edited 1 time
-
zyga
Apr 5, 2017
We are seeing many failures that involve the TestEnsureLoopPrune test.
This test is inherently racy as it uses a actual time to wait for
something to happen. In case the machine is loaded heavily and other
processes contend for resources it may not get scheduled in time for
this to happen
This branch contains (now) a more sophisticated approach suggested
and demonstrated by pedronis.
Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com