cmd/snap-confine: set TMPDIR and TEMPDIR each time #3188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to set TMPDIR and TEMPDIR and point them at /tmp when constructing the mount namespace (the code was simply next to the code that creates private /tmp) but after the move to per-snap persistent namespaces the logic was unchanged. This means that the two variables were set only the first time a given snap application was launched. This patch corrects this by setting all environment in one place, right next to the existing code that changes PATH. Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
chipaca
approved these changes
Apr 13, 2017
stolowski
approved these changes
Apr 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to set TMPDIR and TEMPDIR and point them at /tmp when
constructing the mount namespace (the code was simply next to the code
that creates private /tmp) but after the move to per-snap persistent
namespaces the logic was unchanged. This means that the two variables
were set only the first time a given snap application was launched.
This patch corrects this by setting all environment in one place, right
next to the existing code that changes PATH.
Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com