snap: add `snap refresh --time` option #3240

mvo5 · Apr 26, 2017

Based on #2833

This branch adds a new snap refresh --time option that will display information around the refresh times. This is useful for users to make things more transparent and also useful for debugging.

Here is the example output:

$ snap refresh --time
schedule: 00:00-04:59/5:00-10:59/11:00-16:59/17:00-23:59
last: 2017-04-26 07:47:00 +0200 CEST
next: 2017-04-26 16:33:00 +0200 CEST

One thing I wonder about is if this information should be part of sysinfo or if we should create a dedicated endpoint. The branch is currently using sysinfo, but it seems a dedicated endpoint might be needed anyway when we implement something like snap refresh --delay 2h. Opinions welcome.

chipaca · Apr 26, 2017

chipaca approved these changes Apr 26, 2017

View changes

+1 with a comment :-)

I'd mention here that adding --time will not perform a refresh

(I see that list has the same problem of not saying “this will not perform the action”)

10:57 < mvo_> Chipaca: I like your suggestion about the --time help output. how about "Only show refresh time information" or "Only show refresh times information but not 
              perform any refresh"?
10:59 < zyga> mvo_: maybe `snap refresh --query`

zyga · Apr 26, 2017

zyga reviewed Apr 26, 2017

View changes

One question for Schedule.String below

I'd mention here that adding --time will not perform a refresh

(I see that list has the same problem of not saying “this will not perform the action”)

10:57 < mvo_> Chipaca: I like your suggestion about the --time help output. how about "Only show refresh time information" or "Only show refresh times information but not 
              perform any refresh"?
10:59 < zyga> mvo_: maybe `snap refresh --query`

Is this a typo? The start:end vs start-end below?

Yes, thank you very much for spotting this!

zyga · Apr 26, 2017

zyga reviewed Apr 26, 2017

View changes

Don't we have snap debug ensure-state-soon for this?

pedronis · Apr 28, 2017

pedronis reviewed Apr 28, 2017

View changes

they should grow a doc comment I think, that also explains they need to be used with the state lock

pedronis · Apr 28, 2017

pedronis approved these changes Apr 28, 2017

View changes

lgtm

pedronis · Apr 28, 2017

Personally I think it's fine to expose this on /system-info, and maybe/likely later repeat it on GET of some kind of /refresh(-schedule) endpoint as well, once we need an endpoint to control this as well

robert-ancell · Jun 14, 2017

I just noticed this change, I've put some documentation in https://github.com/snapcore/snapd/wiki/REST-API but a couple of questions:

The time formats are inconsistent with the rest of snapd - e.g. they don't match install-date from snap objects.

Only my system:
system-info: 2017-06-14 09:04:00 +1200 NZST
install-date: 2017-02-07T06:49:09+13:00

Could we change them to use the RFC3339 UTC format?

What format is the schedule in?

robert-ancell · Jun 26, 2017

PR for date formats #3528

pedronis requested a review from niemeyer Apr 27, 2017

@@ -919,6 +941,7 @@ func init() {
          		waitDescs.also(channelDescs).also(modeDescs).also(map[string]string{
          			"revision":          i18n.G("Refresh to the given revision"),
          			"list":              i18n.G("Show available snaps for refresh"),
+        +			"time":              i18n.G("Show auto refresh information"),

@@ -919,6 +941,7 @@ func init() {
          		waitDescs.also(channelDescs).also(modeDescs).also(map[string]string{
          			"revision":          i18n.G("Refresh to the given revision"),
          			"list":              i18n.G("Show available snaps for refresh"),
+        +			"time":              i18n.G("Show auto refresh information"),

@@ -62,6 +66,13 @@ type Schedule struct {
          	Weekday string
          }
+        +func (sched *Schedule) String() string {
+        +	if sched.Weekday == "" {
+        +		return fmt.Sprintf("%s:%s", sched.Start, sched.End)

                      break
                  fi
-        -        sleep 1
+        +        echo "Doing something that triggers ensure"
+        +        snap install test-snapd-python-webserver

@@ -450,15 +450,23 @@ func autoRefreshInFlight(st *state.State) bool {
          	return false
          }
-        -func lastRefresh(st *state.State) (time.Time, error) {
+        +func (m *SnapManager) LastRefresh() (time.Time, error) {

snapcore/snapd

snap: add `snap refresh --time` option #3240

mvo5 commented Apr 26, 2017 •

Edited 1 time

mvo5
Apr 27, 2017

mvo5 and others added some commits Jan 31, 2017

chipaca approved these changes Apr 26, 2017

View changes

zyga reviewed Apr 26, 2017

View changes

mvo5 added some commits Apr 26, 2017

zyga reviewed Apr 26, 2017

View changes

mvo5 added some commits Apr 26, 2017

pedronis requested a review from niemeyer Apr 27, 2017

pedronis reviewed Apr 28, 2017

View changes

pedronis approved these changes Apr 28, 2017

View changes

pedronis commented Apr 28, 2017

chipaca merged commit `cbd7b51` into snapcore:master May 4, 2017
5 of 6 checks passed

5 of 6 checks passed

robert-ancell commented Jun 14, 2017

robert-ancell commented Jun 26, 2017

snapcore/snapd

Join GitHub today

snap: add `snap refresh --time` option #3240

Conversation

mvo5 commented Apr 26, 2017 • edited Edited 1 time mvo5 Apr 27, 2017

mvo5 and others added some commits Jan 31, 2017

Some checks were not successful

Some checks were not successful

All checks have passed

All checks have passed

Some checks were not successful

All checks have failed

All checks have failed

All checks have failed

All checks have passed

All checks have failed

All checks have failed

All checks have failed

Some checks were not successful

Some checks were not successful

Some checks were not successful

All checks have passed

Some checks were not successful

All checks have passed

Some checks were not successful

Some checks were not successful

Some checks were not successful

Some checks were not successful

All checks have passed

All checks have passed

All checks have passed

Some checks were not successful

Some checks were not successful

All checks have passed

Some checks were not successful

All checks have passed

Some checks were not successful

Some checks were not successful

Some checks were not successful

Some checks were not successful

Some checks were not successful

All checks have failed

Some checks were not successful

All checks have failed

Some checks were not successful

All checks have failed

All checks have failed

All checks have failed

All checks have failed

Some checks were not successful

Some checks were not successful

Some checks were not successful

Some checks were not successful

Some checks were not successful

Some checks were not successful

Some checks were not successful

Some checks were not successful

Some checks were not successful

All checks have passed

Some checks were not successful

Some checks were not successful

Some checks were not successful

All checks have passed

Some checks were not successful

Some checks were not successful

Some checks were not successful

All checks have failed

Some checks were not successful

All checks have failed

All checks have failed

chipaca approved these changes Apr 26, 2017 View changes

All checks have failed

zyga reviewed Apr 26, 2017 View changes

mvo5 added some commits Apr 26, 2017

All checks have passed

Some checks were not successful

zyga reviewed Apr 26, 2017 View changes

mvo5 added some commits Apr 26, 2017

All checks have passed

Some checks were not successful

mvo5 commented Apr 26, 2017 •

Edited 1 time

mvo5
Apr 27, 2017

chipaca approved these changes Apr 26, 2017

View changes

zyga reviewed Apr 26, 2017

View changes

zyga reviewed Apr 26, 2017

View changes

pedronis reviewed Apr 28, 2017

View changes

pedronis approved these changes Apr 28, 2017

View changes

chipaca merged commit `cbd7b51` into snapcore:master May 4, 2017
5 of 6 checks passed