many: fix tests with go1.8 / artful #3250
Conversation
mvo5
force-pushed
the
fix-tests-for-go1.8
branch
from
7a701b4
to
17ee3a9
Compare
mvo5
force-pushed
the
fix-tests-for-go1.8
branch
from
17ee3a9
to
d9e2ce5
Compare
mvo5
changed the title
| c.Check(all, Contains, &builtin.UhidInterface{}) | ||
| c.Check(all, Contains, &builtin.Unity7Interface{}) | ||
| c.Check(all, DeepContains, &builtin.BluezInterface{}) | ||
| c.Check(all, DeepContains, &builtin.BoolFileInterface{}) |
There was a problem hiding this comment.
now I really wonder how this was working before
There was a problem hiding this comment.
I see two possibilities:
- compiler optimization resulted in the same pointer being returned for both
- check actually handing pointers to simple structures the same way as it would if the structure is passed by value
There was a problem hiding this comment.
I hope for 1 (bad on go side), I might try to double-check that
There was a problem hiding this comment.
yes, it's 1 and something has changed, it's important to note that those structs are zero-sized.
The langref has this to say (at the very end):
"Two distinct zero-size variables may have the same address in memory."
may not must, so both <1.8 and 1.8 are doing acceptable things but the test was broken
There was a problem hiding this comment.
O-M-G that is utterly terrible. I'm happy that they changed this in 1.8.
spread.yaml
Outdated
| - ubuntu-17.10-ppc64el: | ||
| username: ubuntu | ||
| password: ubuntu | ||
| - ubuntu-17.04-armhf: |
There was a problem hiding this comment.
This looks like a copy-paste bug, I think you wanted 17.10-armhf
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
Also run new "artful" autopkgtest hook that should ensure we run not into failures for this anymore.
This will also need to be distro-pachted into the artful package to make the build (or our SRU will be blocked on this).