Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
cmd/snap-confine/tests: fix shellcheck on recently added files #3258
Conversation
| @@ -0,0 +1,83 @@ | ||
| +// -*- Mode: Go; indent-tabs-mode: t -*- |
| @@ -60,7 +60,7 @@ SHM="$(mktemp -d -p /run/shm)" | ||
| trap 'rm -rf $TMP $SHM' EXIT | ||
| # name snap-confine as the test name for improved logging | ||
| -L="$TMP/`basename $0`" | ||
| +L="$TMP/$(basename "$0")" |
ogra1
May 2, 2017
Contributor
only do:
L=$TMP/$(basename "$0")
there shoudl be no need for the outer quotes that makes it more confusing to read...
Some checks were not successful
|
LGTM |
|
Verified this fixes the build issues on Fedora. |
Some checks were not successful
zyga
merged commit 8cc88b8
into
snapcore:master
May 3, 2017
2 of 7 checks passed
xenial-i386
autopkgtest finished (failure)
Details
artful-amd64
autopkgtest running
Details
xenial-amd64
autopkgtest running
Details
yakkety-amd64
autopkgtest running
Details
zesty-amd64
autopkgtest running
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
xenial-ppc64el
autopkgtest finished (success)
Details
zyga
deleted the
zyga:fix/shellcheck
branch
May 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
zyga commentedMay 2, 2017
Shellcheck is not tested automatically becauseof packaging issues related to
that. This has lead to an issue where we merged something that fails (harmless)
shellcheck verification and is a problem for downstream packaging.
Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com