cmd/snap-confine/tests: fix shellcheck on recently added files #3258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morphis
suggested changes
May 2, 2017
interfaces/builtin/background.go
Outdated
| @@ -0,0 +1,83 @@ | |||
| // -*- Mode: Go; indent-tabs-mode: t -*- | |||
There was a problem hiding this comment.
This file looks like it doesn't belong into this PR.
ogra1
approved these changes
May 2, 2017
| @@ -60,7 +60,7 @@ SHM="$(mktemp -d -p /run/shm)" | |||
| trap 'rm -rf $TMP $SHM' EXIT | |||
|
|
|||
| # name snap-confine as the test name for improved logging | |||
| L="$TMP/`basename $0`" | |||
| L="$TMP/$(basename "$0")" | |||
There was a problem hiding this comment.
only do:
L=$TMP/$(basename "$0")
there shoudl be no need for the outer quotes that makes it more confusing to read...
There was a problem hiding this comment.
I think shellcheck disagrees.
Shellcheck is not tested automatically becauseof packaging issues related to that. This has lead to an issue where we merged something that fails (harmless) shellcheck verification and is a problem for downstream packaging. Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
|
LGTM |
|
Verified this fixes the build issues on Fedora. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shellcheck is not tested automatically becauseof packaging issues related to
that. This has lead to an issue where we merged something that fails (harmless)
shellcheck verification and is a problem for downstream packaging.
Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com