configstate: return error if patch is invalid #3280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`snap set` silently ignores invalid keys/values by not checking if the transaction successfully sets them. Start checking, and if they weren't successfully set, return an error. LP: #1689396 Signed-off-by: Kyle Fazzari <kyle@canonical.com>
kyrofa
force-pushed
the
bugfix/1689396/snap_set_invalid_key
branch
from
6623ebe
to
7e955d0
Compare
chipaca
approved these changes
May 9, 2017
|
Thanks guys 😃 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
snap setsilently ignores invalid keys/values by not checking if the transaction successfully sets them. This PR fixes LP: #1689396 by checking, and if they weren't successfully set, returning an error.