tests/lib: abstract build dependency installation a bit more #3357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvo5
reviewed
May 22, 2017
tests/lib/prepare-project.sh
Outdated
|
|
||
| # in 16.04: apt build-dep -y ./ | ||
| quiet apt-get install -y $(gdebi --quiet --apt-line ./debian/control) | ||
| . "$TESTSLIB/distro.sh" |
There was a problem hiding this comment.
This looks like a nice abstraction. However I wonder if it would be better to move this into pkgdb.sh as this is currently the central place of knowledge about pkg names on various distros.
There was a problem hiding this comment.
Sounds good, let me do that.
mvo5
approved these changes
May 22, 2017
morphis
force-pushed
the
f/abstract-build-dep-installation
branch
from
7bdc164
to
ab5723d
Compare
morphis
force-pushed
the
f/abstract-build-dep-installation
branch
2 times, most recently
from
b42d62d
to
c970ee5
Compare
morphis
force-pushed
the
f/abstract-build-dep-installation
branch
from
c970ee5
to
e5ad609
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.