Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interfaces: disable "mknod |N" in the default seccomp template again #3397

Merged
merged 1 commit into from May 31, 2017

Commits on May 24, 2017

  1. Disable "mknod |N" in the default seccomp template again

    This partially reverts a previous commit to allow mknod/mknodat
    for regular files, pipes and sockets (and not block or char
    devices).
    
    The reason for the revert is described in:
    https://forum.snapcraft.io/t/snapd-2-25-blocked-because-of-possible-revert-race-condition
    
    In a nutshell there is a race-condition when doing the following:
    $ snap refresh core; snap install daemon; snap revert core; reboot
    
    when the system reboots the seccomp profile will contain symbols
    (the |N syntax) that snap-confine from the old core does not
    understands. Snapd will rewrite the seccomp profile on startup,
    however there is no gurantee currently that this rewrite will
    happen before the installed software "daemon" starts which makes
    this racy and we see real bugs because of this.
    
    So we revert the new syntax for now to unblock 2.25+ and work
    on a plan to properly fix this.
    mvo5 committed May 24, 2017
    Configuration menu
    Copy the full SHA
    055ac22 View commit details
    Browse the repository at this point in the history