Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
packaging/{opensuse,fedora}: allow package build with testkeys included #3450
Conversation
added some commits
Jun 8, 2017
Some checks were not successful
codecov-io
commented
Jun 9, 2017
•
Edited 1 time
-
codecov-io
Jun 19, 2017
Edited 1 time
-
Jun 19, 2017
Codecov Report
@@ Coverage Diff @@
## master #3450 +/- ##
==========================================
- Coverage 77.15% 77.14% -0.01%
==========================================
Files 373 373
Lines 25793 25793
==========================================
- Hits 19901 19899 -2
- Misses 4134 4136 +2
Partials 1758 1758
Continue to review full report at Codecov.
|
| -%gobuild -o bin/snapctl %{import_path}/cmd/snapctl | ||
| -%gobuild -o bin/snapd %{import_path}/cmd/snapd | ||
| -%gobuild -o bin/snap-update-ns %{import_path}/cmd/snap-update-ns | ||
| +# We have to build snapd first to prevent the build from |
| +GOFLAGS="-tags withtestkeys" | ||
| +%endif | ||
| + | ||
| +# We have to build snapd first to prevent the build from |
zyga
Jun 9, 2017
Contributor
I don't think anything else cares about test keys, if that lets you simplify things, go for it!
| +# so we we have to invoke `go install` here manually. | ||
| +export GOPATH=%{_builddir}/go:%{_libdir}/go/contrib | ||
| +export GOBIN=%{_builddir}/go/bin | ||
| +go install -s -v -p 4 -x -tags withtestkeys github.com/snapcore/snapd/cmd/snapd |
zyga
Jun 9, 2017
Contributor
Nitpick, can you use long forms or document the meaning of the switches above in a comment, for the next reader?
| +GOFLAGS= | ||
| +%if 0%{?with_test_keys} | ||
| +GOFLAGS="-tags withtestkeys" | ||
| +%endif |
added some commits
Jun 12, 2017
Some checks were not successful
Some checks were not successful
| -%gobuild -o bin/snapctl %{import_path}/cmd/snapctl | ||
| -%gobuild -o bin/snapd %{import_path}/cmd/snapd | ||
| -%gobuild -o bin/snap-update-ns %{import_path}/cmd/snap-update-ns | ||
| +GOFLAGS= |
morphis
Jun 19, 2017
Contributor
Who else uses GOFLAGS? Nothing in the spec file does and nothing of the RPM golang macros does.
All checks have passed
mvo5
merged commit 0309a02
into
snapcore:master
Jun 19, 2017
7 checks passed
artful-amd64
autopkgtest finished (success)
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
xenial-amd64
autopkgtest finished (success)
Details
xenial-i386
autopkgtest finished (success)
Details
xenial-ppc64el
autopkgtest finished (success)
Details
yakkety-amd64
autopkgtest finished (success)
Details
zesty-amd64
autopkgtest finished (success)
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
morphis commentedJun 9, 2017
Special build with test keys enabled is necessary for a few spread tests.