tests/main: use pkgdb function in more test cases

[morphis]

No description provided.

[zyga]

+1 but two questions asked.

[zyga]

Hmm, I wonder what this thing is about, why did we apt-get install ... nothing here?

[morphis]

apt-get install -f -y actually does dependency cleanup if you did a purge via dpkg --purge

[zyga]

Is the --no-install-recommends relevant? I wonder why it was here.

[morphis]

Good catch, I actually added to support for that to the distro_install_package command but looks like this was dropped during the rebase/master I did

[morphis]

Fixed that. distro_install_package now accepts --no-install-recommends as argument.

[Conan-Kudo]

It might be better to be more generic: --no-weak-deps, which for Debian could be --no-install-recommends. For openSUSE, it would be --no-recommends, and for Fedora, it'd be --setopt=install_weak_deps=False

[morphis]

Let me add these thanks.

[morphis]

Done.

[Conan-Kudo]

Why are you doing -y twice? It's already being used as a global flag...

[morphis]

You're faster than me, already about to push another change to fix that.

[Conan-Kudo]

You still need -y after install subcommand for Zypper.

[morphis]

Narf. Never do multiple things at the same time :-)

[codecov-io]

Codecov Report

Merging #3455 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3455      +/-   ##
==========================================
+ Coverage   77.15%   77.18%   +0.02%     
==========================================
  Files         373      375       +2     
  Lines       25793    25837      +44     
==========================================
+ Hits        19901    19941      +40     
- Misses       4134     4136       +2     
- Partials     1758     1760       +2

Impacted Files	Coverage Δ
dirs/dirs.go	96.77% <0%> (-0.06%)	⬇️
daemon/api.go	73.18% <0%> (-0.01%)	⬇️
interfaces/builtin/content.go	80.73% <0%> (ø)	⬆️
cmd/snap/cmd_run.go	64.51% <0%> (ø)	⬆️
interfaces/policy/basedeclaration.go	40.74% <0%> (ø)	⬆️
interfaces/builtin/udisks2.go	82.5% <0%> (ø)	⬆️
cmd/snap/cmd_get_base_declaration.go	75% <0%> (ø)
interfaces/builtin/greengrass_support.go	100% <0%> (ø)
overlord/snapstate/snapstate.go	81.52% <0%> (+0.23%)	⬆️
asserts/repair.go	95.55% <0%> (+1.61%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8064fa0...0a690c7. Read the comment docs.

[fgimenez]

LGTM

[fgimenez]

There's an issue with the management of --no-install-recommends https://travis-ci.org/snapcore/snapd/builds/242007338#L1944

[morphis]

@fgimenez Thanks, yeah I saw that already. Has something to do with the quoting of APT_FLAGS, not yet sure what it is.