tests/main: use pkgdb function in more test cases #3455
Conversation
| @@ -29,8 +31,7 @@ execute: | | |||
|
|
|||
| . "$TESTSLIB/pkgdb.sh" | |||
| echo "Ensure core is gone and we have ubuntu-core instead" | |||
| dpkg --purge --force-depends snapd | |||
| apt-get install -f -y | |||
There was a problem hiding this comment.
Hmm, I wonder what this thing is about, why did we apt-get install ... nothing here?
There was a problem hiding this comment.
apt-get install -f -y actually does dependency cleanup if you did a purge via dpkg --purge
| echo "Given openvswitch is installed" | ||
| apt install -y --no-install-recommends openvswitch-switch |
There was a problem hiding this comment.
Is the --no-install-recommends relevant? I wonder why it was here.
There was a problem hiding this comment.
Good catch, I actually added to support for that to the distro_install_package command but looks like this was dropped during the rebase/master I did
There was a problem hiding this comment.
Fixed that. distro_install_package now accepts --no-install-recommends as argument.
There was a problem hiding this comment.
It might be better to be more generic: --no-weak-deps, which for Debian could be --no-install-recommends. For openSUSE, it would be --no-recommends, and for Fedora, it'd be --setopt=install_weak_deps=False
There was a problem hiding this comment.
Let me add these thanks.
morphis
force-pushed
the
f/use-pkgdb-in-more-tests
branch
from
9e771d2
to
d1a33e4
Compare
morphis
force-pushed
the
f/use-pkgdb-in-more-tests
branch
from
d1a33e4
to
2653471
Compare
tests/lib/pkgdb.sh
Outdated
| ;; | ||
| fedora-*) | ||
| dnf -q -y install -y "$DNF_FLAGS" $package_name | ||
| dnf -q -y install "$DNF_FLAGS" -y $package_name |
There was a problem hiding this comment.
Why are you doing -y twice? It's already being used as a global flag...
There was a problem hiding this comment.
You're faster than me, already about to push another change to fix that.
morphis
force-pushed
the
f/use-pkgdb-in-more-tests
branch
from
14024d4
to
0465786
Compare
tests/lib/pkgdb.sh
Outdated
| ;; | ||
| opensuse-*) | ||
| zypper -q install -y "$ZYPPER_FLAGS" $package_name | ||
| zypper -q install "$ZYPPER_FLAGS" $package_name |
There was a problem hiding this comment.
You still need -y after install subcommand for Zypper.
There was a problem hiding this comment.
Narf. Never do multiple things at the same time :-)
morphis
force-pushed
the
f/use-pkgdb-in-more-tests
branch
from
0465786
to
9926015
Compare
Codecov Report
@@ Coverage Diff @@
## master #3455 +/- ##
==========================================
+ Coverage 77.15% 77.18% +0.02%
==========================================
Files 373 375 +2
Lines 25793 25837 +44
==========================================
+ Hits 19901 19941 +40
- Misses 4134 4136 +2
- Partials 1758 1760 +2
Continue to review full report at Codecov.
|
|
There's an issue with the management of |
|
@fgimenez Thanks, yeah I saw that already. Has something to do with the quoting of APT_FLAGS, not yet sure what it is. |
No description provided.