many: switch to use http numeric statuses as agreed #3486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…convert 401 into please buy, atm is just confusing
chipaca
approved these changes
Jun 15, 2017
| @@ -698,15 +700,15 @@ func (t *remoteRepoTestSuite) TestActualDownloadNonPurchased401(c *C) { | |||
| var buf bytes.Buffer | |||
| err := download(context.TODO(), "foo", "sha3", mockServer.URL, nil, theStore, nopeSeeker{&buf}, -1, nil) | |||
| c.Assert(err, NotNil) | |||
| c.Check(err.Error(), Equals, "Please buy foo before installing it.") | |||
| c.Check(err.Error(), Equals, "please buy foo before installing it.") | |||
run-checks
Outdated
| echo 'Check for usages of http.Status*' | ||
| got="" | ||
| for dir in $(go list -f '{{.Dir}}' ./... | grep -v '/vendor/' ); do | ||
| s="$(grep -nE "http\.Status" "$dir"/*.go |grep -vE "http\.StatusText\(" || true)" |
There was a problem hiding this comment.
you could also write that grep -nP 'http\.Status(?!Text)', fwiw.
store/store_test.go
Outdated
| n := 0 | ||
| mockServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| n++ | ||
| w.WriteHeader(http.StatusUnauthorized) | ||
| // XXX: the server doesn't behave correctly ATM | ||
| // but 401 for non purchases is the unlikely case so far |
There was a problem hiding this comment.
is this still true? I thought work was being done on this front
There was a problem hiding this comment.
yes, is still true to some extent
Codecov Report
@@ Coverage Diff @@
## master #3486 +/- ##
=======================================
Coverage 77.16% 77.16%
=======================================
Files 373 373
Lines 25793 25793
=======================================
Hits 19903 19903
Misses 4133 4133
Partials 1757 1757
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also change the code that was interpreting a 401 as "please buy" which is the unlikely case.
Also have a static check to make sure we continue with this style.