tests: speedup prepare statement part 1 #3564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is proposing a simple change to save about 200 ms for every test by changing how service units are get. Also is reducing some time in the econnreset test.
Codecov Report
@@ Coverage Diff @@
## master #3564 +/- ##
==========================================
- Coverage 76.76% 76.76% -0.01%
==========================================
Files 379 379
Lines 26277 26277
==========================================
- Hits 20172 20171 -1
- Misses 4313 4314 +1
Partials 1792 1792
Continue to review full report at Codecov.
|
stolowski
approved these changes
Jul 7, 2017
| mounts="$(systemctl list-unit-files --full | grep "^$escaped_snap_mount_dir[-.].*\.mount" | cut -f1 -d ' ')" | ||
| services="$(systemctl list-unit-files --full | grep "^$escaped_snap_mount_dir[-.].*\.service" | cut -f1 -d ' ')" | ||
| for unit in $services $mounts; do | ||
| units="$(systemctl list-unit-files --full | grep -e "^$escaped_snap_mount_dir[-.].*\.mount" -e "^$escaped_snap_mount_dir[-.].*\.service" | cut -f1 -d ' ')" |
pedronis
approved these changes
Jul 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is proposing a simple change to save about 200 ms for every
test by changing how service units are get. Also is reducing some time
in the econnreset test.