Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snap-seccomp: add secondary arch for unrestricted snaps as well #3603

Merged
merged 1 commit into from Jul 18, 2017

Conversation

mvo5
Copy link
Collaborator

@mvo5 mvo5 commented Jul 18, 2017

When creating a @unrestricted filter we need to whitelist all
architectures or e.g. i386 apps on amd64 will fail.

When creating a @unrestricted filter we need to whitelist all
architectures or e.g. i386 apps on amd64 will fail.
Copy link
Collaborator

@zyga zyga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Thanks for the commit message :-)

@zyga
Copy link
Collaborator

zyga commented Jul 18, 2017

We could also use a test for this. I don't think we have one.

@codecov-io
Copy link

Codecov Report

Merging #3603 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3603      +/-   ##
==========================================
- Coverage    74.9%   74.89%   -0.01%     
==========================================
  Files         380      380              
  Lines       32949    32952       +3     
==========================================
- Hits        24682    24681       -1     
- Misses       6475     6478       +3     
- Partials     1792     1793       +1
Impacted Files Coverage Δ
cmd/snap-seccomp/main.go 49.79% <0%> (-0.64%) ⬇️
cmd/snap/cmd_aliases.go 93.33% <0%> (-1.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c9d44f...f3085be. Read the comment docs.

@mvo5 mvo5 merged commit 1436db4 into snapcore:master Jul 18, 2017
@tyhicks
Copy link
Contributor

tyhicks commented Jul 18, 2017

This looks correct to me. Thanks!

Copy link

@jdstrand jdstrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this PR and #3603 (they look the same)?

This looks fine though.

@zyga
Copy link
Collaborator

zyga commented Jul 19, 2017

@jdstrand because this branch is PR #3603? I suspect you meant another PR that targets the release branch though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants