New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to version of golang.org/x/crypto currently in Debian unstable #3639
Conversation
This pulls in a new dependency, golang.org/x/sys, which I have also pinned to the version currently in Debian unstable.
OK so this isn't going to work, this version of x/crypto requires 1.7+ (context in std lib). The tests passed on artful and zesty though so that's encouraging for the Debian update. |
notice that we are pulling in more x/crypto than we really need, not sure the bits we need really need context (we would need to split up the dep pulling though) |
I wonder if setting DH_EXCLUDES to "vendor" would help? |
Why did this pass in xenial then (which still has 1.6.x)? |
I'm slightly worried about excluding the vendor tests, it seems like a nice property that we unit test things at this level. |
That's fair. Is there a timeline/plan for getting off Go 1.6? |
I don't know if we can get off go 1.6 in xenial without full blown backport of 1.8.x - or am I missing something? |
Ah I see, that makes sense. Closing this for now. |
This pulls in a new dependency, golang.org/x/sys, which I have also pinned to
the version currently in Debian unstable.