Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to version of golang.org/x/crypto currently in Debian unstable #3639

Closed
wants to merge 3 commits into from

Conversation

mwhudson
Copy link
Contributor

@mwhudson mwhudson commented Aug 2, 2017

This pulls in a new dependency, golang.org/x/sys, which I have also pinned to
the version currently in Debian unstable.

This pulls in a new dependency, golang.org/x/sys, which I have also pinned to
the version currently in Debian unstable.
@mwhudson
Copy link
Contributor Author

mwhudson commented Aug 3, 2017

OK so this isn't going to work, this version of x/crypto requires 1.7+ (context in std lib). The tests passed on artful and zesty though so that's encouraging for the Debian update.

@pedronis
Copy link
Collaborator

pedronis commented Aug 3, 2017

notice that we are pulling in more x/crypto than we really need, not sure the bits we need really need context (we would need to split up the dep pulling though)

@pedronis pedronis changed the title Update to version of golang.org/x/crypto currently in Debian unstable update to version of golang.org/x/crypto currently in Debian unstable Aug 3, 2017
@mwhudson
Copy link
Contributor Author

mwhudson commented Aug 3, 2017

I wonder if setting DH_EXCLUDES to "vendor" would help?

@zyga
Copy link
Collaborator

zyga commented Aug 4, 2017

Why did this pass in xenial then (which still has 1.6.x)?

@mvo5
Copy link
Contributor

mvo5 commented Aug 9, 2017

I'm slightly worried about excluding the vendor tests, it seems like a nice property that we unit test things at this level.

@mwhudson
Copy link
Contributor Author

mwhudson commented Aug 9, 2017

That's fair.

Is there a timeline/plan for getting off Go 1.6?

@zyga
Copy link
Collaborator

zyga commented Aug 16, 2017

I don't know if we can get off go 1.6 in xenial without full blown backport of 1.8.x - or am I missing something?

@pedronis
Copy link
Collaborator

@mwhudson see #3765 for the approach I mentioned a while ago in a comment, seems to work fine and would have us use the same version (of what we actually use)

@mwhudson
Copy link
Contributor Author

Ah I see, that makes sense. Closing this for now.

@mwhudson mwhudson closed this Aug 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants