Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
update to version of golang.org/x/crypto currently in Debian unstable #3639
Conversation
|
OK so this isn't going to work, this version of x/crypto requires 1.7+ (context in std lib). The tests passed on artful and zesty though so that's encouraging for the Debian update. |
|
notice that we are pulling in more x/crypto than we really need, not sure the bits we need really need context (we would need to split up the dep pulling though) |
pedronis
changed the title from
Update to version of golang.org/x/crypto currently in Debian unstable
to
update to version of golang.org/x/crypto currently in Debian unstable
Aug 3, 2017
|
I wonder if setting DH_EXCLUDES to "vendor" would help? |
mwhudson
added some commits
Aug 4, 2017
|
Why did this pass in xenial then (which still has 1.6.x)? |
|
I'm slightly worried about excluding the vendor tests, it seems like a nice property that we unit test things at this level. |
|
That's fair. Is there a timeline/plan for getting off Go 1.6? |
|
I don't know if we can get off go 1.6 in xenial without full blown backport of 1.8.x - or am I missing something? |
pedronis
referenced this pull request
Aug 18, 2017
Merged
vendor: explode and make more precise our golang.go/x/crypto deps, use same version as Debian unstable #3765
|
Ah I see, that makes sense. Closing this for now. |
mwhudson commentedAug 2, 2017
This pulls in a new dependency, golang.org/x/sys, which I have also pinned to
the version currently in Debian unstable.