tests: download core and ubuntu-core at most once #3641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch relies on snapd's ability to resume partial downloads. In the one-off preparation phase we download a set of snaps, chop off the last byte and move them to /var/lib/snapd/snaps adding the .partial suffix to enable the download beavior. Each test that needs to pull in one of those two fill then take advantage of the existing file and will do minimal network traffic required to achieve this. Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
Codecov Report
@@ Coverage Diff @@
## master #3641 +/- ##
==========================================
- Coverage 75.2% 75.16% -0.04%
==========================================
Files 387 388 +1
Lines 33452 33628 +176
==========================================
+ Hits 25159 25278 +119
- Misses 6481 6534 +53
- Partials 1812 1816 +4
Continue to review full report at Codecov.
|
chipaca
reviewed
Aug 2, 2017
tests/lib/prepare.sh
Outdated
| # There is a bug in snapd where partial file must be a proper | ||
| # prefix of the full file or we make a wrong request to the | ||
| # store. | ||
| truncate --size=$(expr $(stat $snap_file.partial -c %s) - 1) $snap_file.partial |
There was a problem hiding this comment.
truncate --size=-1 would DWYW 😃
There was a problem hiding this comment.
Oh, I didn't know that works. Nice!
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
|
Merging, I just saw another test failing on "whooping" 100KB/s download speed that ended up with timeout. |
chipaca
reviewed
Aug 14, 2017
| # There is a bug in snapd where partial file must be a proper | ||
| # prefix of the full file or we make a wrong request to the | ||
| # store. | ||
| truncate --size=-1 $snap_file.partial |
There was a problem hiding this comment.
@zyga did you land a patch to drop this truncate?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch relies on snapd's ability to resume partial downloads. In
the one-off preparation phase we download a set of snaps, chop off the
last byte and move them to /var/lib/snapd/snaps adding the .partial
suffix to enable the download beavior. Each test that needs to pull in
one of those two fill then take advantage of the existing file and will
do minimal network traffic required to achieve this.
Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com