New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
snapstate: undo a daemon restart on classic if needed #3757
snapstate: undo a daemon restart on classic if needed #3757
Conversation
If we are on classic and have no previous version of core we may have restarted from a distro package into the core snap. We need to undo that restart. See also https://forum.snapcraft.io/t/snapd-not-restarting-on-revert/1679
…rt-no-integration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, log message could be clearer though I think
overlord/snapstate/handlers.go
Outdated
// doUnlinkCurrentSnap() like we usually do when going from | ||
// core snap -> next core snap | ||
if release.OnClassic && newInfo.Type == snap.TypeOS && oldCurrent.Unset() { | ||
t.Logf("Requested daemon restart (undo classic)") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
undo classic initial core install?
Codecov Report
@@ Coverage Diff @@
## master #3757 +/- ##
==========================================
+ Coverage 75.84% 75.85% +<.01%
==========================================
Files 399 399
Lines 34541 34551 +10
==========================================
+ Hits 26197 26207 +10
+ Misses 6481 6480 -1
- Partials 1863 1864 +1
Continue to review full report at Codecov.
|
This failed iwth
|
…rt-no-integration
If we are on classic and have no previous version of core
we may have restarted from a distro package into the core
snap. We need to undo that restart.
This is essentially #3750 without the controversial integration test.
See also
https://forum.snapcraft.io/t/snapd-not-restarting-on-revert/1679