Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
cmd/snap-confine: allow reading /proc/filesystems #3790
Conversation
zyga
requested a review
from
jdstrand
Aug 23, 2017
codecov-io
commented
Aug 23, 2017
Codecov Report
@@ Coverage Diff @@
## master #3790 +/- ##
=========================================
- Coverage 75.81% 75.8% -0.02%
=========================================
Files 402 402
Lines 34741 34741
=========================================
- Hits 26340 26334 -6
- Misses 6527 6531 +4
- Partials 1874 1876 +2
Continue to review full report at Codecov.
|
zyga
merged commit e012d0c
into
snapcore:master
Aug 23, 2017
6 of 7 checks passed
yakkety-amd64
autopkgtest running
Details
artful-amd64
autopkgtest finished (success)
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
xenial-amd64
autopkgtest finished (success)
Details
xenial-i386
autopkgtest finished (success)
Details
xenial-ppc64el
autopkgtest finished (success)
Details
zesty-amd64
autopkgtest finished (success)
Details
zyga
deleted the
zyga:tweak/opensuse-proc-filesystems
branch
Aug 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
zyga commentedAug 23, 2017
This rule is required to make snap-confine work on openSUSE tumbleweed.
The rule is presumably required by selinux as seen in the following
strace fragment:
23075 statfs("/sys/fs/selinux", 0x7ffdaa3ad9b0) = -1 ENOENT (No such file or directory)
23075 statfs("/selinux", {f_type=BTRFS_SUPER_MAGIC, f_bsize=4096, f_blocks=10486528, f_bfree=6317286, f_bavail=5992378, f_files=0, f_ffree=0, f_fsid={val=[2999193500, 2112688126]}, f_namelen=255, f_frsize=4096, f_flags=ST_VALID|ST_RELATIME}) = 0
23075 brk(NULL) = 0x20b4000
23075 brk(0x20d5000) = 0x20d5000
23075 open("/proc/filesystems", O_RDONLY) = 3
Signed-off-by: Zygmunt Krynicki me@zygoon.pl