Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interfaces: add plugRef/slotRef helpers for PlugInfo/SlotInfo #4007

Merged
merged 4 commits into from Oct 25, 2017

Conversation

stolowski
Copy link
Contributor

Note: based on #3972, the actual diff is very small. This PR just adds plugRef and slotRef helper methods, per the plan outlined here https://forum.snapcraft.io/t/preparing-the-interfaces-logic-for-connection-hooks/2184

Copy link
Collaborator

@zyga zyga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for 21cc694

Copy link
Collaborator

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 For the specific commit

@codecov-io
Copy link

codecov-io commented Oct 5, 2017

Codecov Report

Merging #4007 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4007      +/-   ##
=========================================
+ Coverage    75.8%   75.8%   +<.01%     
=========================================
  Files         433     433              
  Lines       37287   37291       +4     
=========================================
+ Hits        28266   28270       +4     
  Misses       7046    7046              
  Partials     1975    1975
Impacted Files Coverage Δ
interfaces/core.go 97.4% <100%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4eb1bb...3ca4cf3. Read the comment docs.

@stolowski stolowski merged commit 9871f86 into snapcore:master Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants